Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] OpenTelemetry - tests performance after adding span from wrapper (node) #3348

Closed
adarovadya opened this issue Mar 8, 2025 · 1 comment
Closed

[Task] OpenTelemetry - tests performance after adding span from wrapper (node) #3348

adarovadya opened this issue Mar 8, 2025 · 1 comment
Assignees
@adarovadya
Labels
2_0_candidate Candidate task for version 2.0 node Node.js wrapper Rust core redis-rs/glide-core matter testing Everything about testing
Milestone
1.4

Comments

@adarovadya
Copy link
Collaborator

adarovadya commented Mar 8, 2025 •
edited
Loading

Description

In order to add the command root span and measure the command lifetime we added FFI calls which can effect on the performance.
The goal of this task is to run the same performance tests with and without my changes and to compare the results.
Clone the changes from - #3391

Checklist

...

Additional Notes

No response
@adarovadya adarovadya added node Node.js wrapper Rust core redis-rs/glide-core matter testing Everything about testing labels Mar 8, 2025
@adarovadya adarovadya added this to the 1.4 milestone Mar 8, 2025
@adarovadya adarovadya self-assigned this Mar 8, 2025
@adarovadya
Copy link
Collaborator Author

done #3452

@meitalkra meitalkra added the 2_0_candidate Candidate task for version 2.0 label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adarovadya adarovadya

Labels
2_0_candidate Candidate task for version 2.0 node Node.js wrapper Rust core redis-rs/glide-core matter testing Everything about testing
Projects
Valkey-GLIDE - internal
Status: Done
Milestone
1.4
Development

No branches or pull requests
2 participants
@adarovadya @meitalkra