Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit access specifiers for class member functions #103

Open
malleoz opened this issue May 31, 2024 · 0 comments
Open

Audit access specifiers for class member functions #103

malleoz opened this issue May 31, 2024 · 0 comments
Labels
engine Code involving engine (C++) P4 Priority: Trivial quality Code quality improvements

Comments

@malleoz
Copy link
Contributor

malleoz commented May 31, 2024

For example, KartMove has a lot of public functions which are only ever called by calc(). We should make sure that we only expose the bare minimum.
@vabold vabold added engine Code involving engine (C++) improvement Improvement to existing code P4 Priority: Trivial labels Jun 1, 2024
@vabold vabold added quality Code quality improvements and removed improvement Improvement to existing code labels Jul 19, 2024
@malleoz malleoz mentioned this issue Oct 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine Code involving engine (C++) P4 Priority: Trivial quality Code quality improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Kart namespace: Limit function visibility malleoz/Kinoko
2 participants
@malleoz @vabold