Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize function order in KartMove.cc/hh #101

Open
malleoz opened this issue May 31, 2024 · 0 comments
Open

Reorganize function order in KartMove.cc/hh #101

malleoz opened this issue May 31, 2024 · 0 comments
Labels
engine Code involving engine (C++) P3 Priority: Low quality Code quality improvements

Comments

@malleoz
Copy link
Contributor

malleoz commented May 31, 2024

We have the following janky order that should be reorganized/cleaned up:

  • ctor/dtor
  • some virtuals
  • some non-virtuals
  • non-virtual calc functions
  • virtual, (mostly) calc functions
  • non-virtual calc functions
  • some boost related calc functions
  • setters
  • getters

Less chaotic in Bike derived class, but you get the gist.

@vabold vabold added engine Code involving engine (C++) P3 Priority: Low improvement Improvement to existing code labels May 31, 2024
@vabold vabold added quality Code quality improvements and removed improvement Improvement to existing code labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Code involving engine (C++) P3 Priority: Low quality Code quality improvements
Projects
None yet
Development

No branches or pull requests

2 participants