Skip to content
This repository was archived by the owner on Oct 8, 2020. It is now read-only.

vaadin-confirm-dialog 1.2.0 breaks the npm dependencies #99

Closed
alump opened this issue May 20, 2020 · 9 comments
Closed

vaadin-confirm-dialog 1.2.0 breaks the npm dependencies #99

alump opened this issue May 20, 2020 · 9 comments

Comments

@alump
Copy link

alump commented May 20, 2020

When using Vaadin 14.1.x series. If I add vaadin-rich-text-editor-flow dependency... it will break the client side once RichTextEditor gets included to bundle.

This happens because @vaadin/vaadin-rich-text-editor has @vaadin/vaadin-confirm-dialog dependency ^1.1.0 -> which loads 1.2.0. Which then ends up depending on @vaadin/vaadin-lumo-styles ^1.6.0.

Same time @vaadin/flow-deps has dependency to 1.5.0 of lumo-styles.

This causes duplicate dependencies that breaks the client side.

@alump
Copy link
Author

alump commented May 20, 2020

Workaround, have maven dependency to vaadin-confirm-dialog-flow in you project that will force it to stay in 1.1.x versions assuming you use the managed dependency version 2.0.4.

But I assume the NPM should be correct? Or then vaadin-rich-text-editor-flow should bring in maven dependency to force version to be right... if NPM version issues won't be resolved.

@alvarezguille
Copy link
Member

Just to verify, are you using vaadin-core and then adding the pro dependencies one by one?

@alump
Copy link
Author

alump commented May 25, 2020

Yes. only free vaadin dependencies (aka core), then add vaadin-confirm-dialog-flow dependency and issue above happens.

@alump
Copy link
Author

alump commented May 27, 2020

project has com.vaadin vaadin-bom dependency of 14.1.4

@alump
Copy link
Author

alump commented May 27, 2020

Tried to clean up everything, and rebuild things. Now I didn't get 1.6.0 version of vaadin-lumo-styles. So I don't know what caused it pull 1.6.0 when I added vaadin-rich-text-editor dependency. Maybe it was some strange existing package-lock issue again that happened was it wasn't removed.

Maybe some strange issue when you move backward on framework 14.1.x to 14.1.x-n ... but don't remove package-lock.json?

@fschon
Copy link

fschon commented May 28, 2020

I have the same problem, I just don't know where it breaks the client side.

When including dependencies:

        <dependency>
            <groupId>com.vaadin</groupId>
            <artifactId>vaadin-core</artifactId>
        </dependency>
        <dependency>
            <groupId>com.vaadin</groupId>
            <artifactId>vaadin-rich-text-editor-flow</artifactId>
        </dependency>

Then none of my Polymer JsModule templates will render on the clients. Other non polymer components render fine.

If I change <artifactId>vaadin-core</artifactId> to include all pro components <artifactId>vaadin</artifactId> then the Polymer templates display again.

I can't see any errors in the Javascript or server side logs.

@TatuLund
Copy link

The same issue can happen also with Crud.

@TatuLund
Copy link

TatuLund commented Jun 3, 2020

See also vaadin/flow#8475

@alvarezguille
Copy link
Member

Should be fixed in 14.3 with pnpm, please reopen if it can be reproduced

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants