Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring SerializationDebugRequestHandler as a VaadinRequestInterceptor #134

Open
mcollovati opened this issue Apr 19, 2024 · 0 comments
Open

Consider refactoring SerializationDebugRequestHandler as a VaadinRequestInterceptor #134

mcollovati opened this issue Apr 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mcollovati
Copy link
Contributor

Currently, SerializationDebugRequestHandler is implemented as a RequestHandler.
Since it runs before UIDLRequestHandler, an and additional servlet Filter is required to execute the serialization test after the UI changes are applied.

The code could probably be simplified by refactoring SerializationDebugRequestHandler into a VaadinRequestInterceptor (introduced in Vaadin 24.2) that provides hooks for request start and end, removing the need for the Filter.
@mcollovati mcollovati added the enhancement New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcollovati