Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all vaadin configuration properties are visible in Intellij #20064

Open
jorgheymans opened this issue Sep 26, 2024 · 5 comments
Open

not all vaadin configuration properties are visible in Intellij #20064

jorgheymans opened this issue Sep 26, 2024 · 5 comments

Comments

@jorgheymans
Copy link

For example vaadin.closeIdleSessions is not in the list, and IntelliJ flags it yellow. Whatever magic that makes the other properties appear should be applied to all properties here https://vaadin.com/docs/latest/flow/configuration/properties

image

@mshabarov
Copy link
Contributor

Changed the label to investigation, because it looks to me more like a bug, but we have to double check what config parameters are missing in Spring-specific configuration class.

@jorgheymans
Copy link
Author

jorgheymans commented Oct 1, 2024

DefaultDeploymentConfiguration has a lot of the missing properties, but it also has system properties and servlet init-vars it seems. So annotating it with @ConfigurationProperties may not be desirable.

@jcgueriaud1
Copy link
Contributor

@jcgueriaud1
Copy link
Contributor

annotating DefaultDeploymentConfiguration with @ConfigurationProperties may not be desirable.

DefaultDeploymentConfiguration is in Flow and Flow does not depend on Spring. That's the reason it's not possible to annotate it.

@jorgheymans
Copy link
Author

Sure, but technicalities aside, when a developer does ctrl-tab after vaadin. in application.yml, she or he can reasonably expect that all possible properties are listed.

@mshabarov mshabarov moved this from 🪵Product backlog to 🅿️Parking lot in Vaadin Flow ongoing work (Vaadin 10+) Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Normal Priority (P2)
Status: 🅿️Parking lot
Development

No branches or pull requests

3 participants