Skip to content

Commit 7d23cf5

Browse files
caaladorvaadin-bot
authored andcommitted
chore: Update browser details parse log output (#20852)
Do not log the exception stack trace when failing version parse. Message contains alrready required information and the result is -1 and the app stays running. touches #20838
1 parent 84c908b commit 7d23cf5

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

flow-server/src/main/java/com/vaadin/flow/server/WebBrowser.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ public class WebBrowser implements Serializable {
7070
browserDetails = new BrowserDetails(agent) {
7171
@Override
7272
protected void log(String error, Exception e) {
73-
LoggerFactory.getLogger(BrowserDetails.class).error(error,
74-
e);
73+
LoggerFactory.getLogger(BrowserDetails.class).error(error);
7574
}
7675
};
7776
}

flow-server/src/main/java/com/vaadin/flow/shared/BrowserDetails.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,8 +463,8 @@ private int parseVersionPart(String versionString, String partName,
463463
try {
464464
return Integer.parseInt(versionString);
465465
} catch (Exception e) {
466-
log(partName + " version parsing failed for: " + versionString
467-
+ "\nWith userAgent: " + userAgent, e);
466+
log(partName + " version parsing failed for: \"" + versionString
467+
+ "\"\nWith userAgent: " + userAgent, e);
468468
}
469469
return -1;
470470
}

0 commit comments

Comments
 (0)