From 277fb35ecbb1ab659b0a79e37a8d7cd5d376578b Mon Sep 17 00:00:00 2001 From: Vaadin Bot Date: Thu, 16 Jan 2025 07:54:34 +0100 Subject: [PATCH] chore: Update browser details parse log output (#20852) (#20853) Do not log the exception stack trace when failing version parse. Message contains alrready required information and the result is -1 and the app stays running. touches #20838 Co-authored-by: caalador --- .../src/main/java/com/vaadin/flow/server/WebBrowser.java | 3 +-- .../src/main/java/com/vaadin/flow/shared/BrowserDetails.java | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/flow-server/src/main/java/com/vaadin/flow/server/WebBrowser.java b/flow-server/src/main/java/com/vaadin/flow/server/WebBrowser.java index 6d655169c91..5b05a286233 100644 --- a/flow-server/src/main/java/com/vaadin/flow/server/WebBrowser.java +++ b/flow-server/src/main/java/com/vaadin/flow/server/WebBrowser.java @@ -70,8 +70,7 @@ public class WebBrowser implements Serializable { browserDetails = new BrowserDetails(agent) { @Override protected void log(String error, Exception e) { - LoggerFactory.getLogger(BrowserDetails.class).error(error, - e); + LoggerFactory.getLogger(BrowserDetails.class).error(error); } }; } diff --git a/flow-server/src/main/java/com/vaadin/flow/shared/BrowserDetails.java b/flow-server/src/main/java/com/vaadin/flow/shared/BrowserDetails.java index 3209e522244..7011884fc01 100644 --- a/flow-server/src/main/java/com/vaadin/flow/shared/BrowserDetails.java +++ b/flow-server/src/main/java/com/vaadin/flow/shared/BrowserDetails.java @@ -463,8 +463,8 @@ private int parseVersionPart(String versionString, String partName, try { return Integer.parseInt(versionString); } catch (Exception e) { - log(partName + " version parsing failed for: " + versionString - + "\nWith userAgent: " + userAgent, e); + log(partName + " version parsing failed for: \"" + versionString + + "\"\nWith userAgent: " + userAgent, e); } return -1; }