[ConfirmDialog] setCancelButton
should set cancelable consistently
#7024
Labels
refactor
Internal improvement
requires new major
This would be a breaking change
vaadin-confirm-dialog
Describe your motivation
When you set a custom cancel button, some overloads make the dialog cancelable automatically, while others do not:
setCancelButton(String buttonText, ComponentEventListener<CancelEvent> cancelListener)
- CancelablesetCancelButton(String buttonText, ComponentEventListener<CancelEvent> cancelListener, String theme)
- CancelablesetCancelButton(Component component)
- Not cancelablesetCancelButton(Element element)
- Not cancelableDescribe the solution you'd like
The behavior should be consistent, so either all methods make the dialog cancelable, or neither of them does. Same goes for
setRejectButton
.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: