remove unnecessary content resizing algorithm

Author: Joseph Lowinske

_includes/sidebar.html

@@ -10,8 +10,8 @@
       var navgocoOptions = {
         caretHtml: '',
         accordion: false,
-        openClass: 'active--expand', // open
-        save: false, // leave false or nav highlighting doesn't work right
+        openClass: 'active--expand',
+        save: false,
         cookie: {
           name: 'navgoco',
           expires: false,
@@ -23,35 +23,7 @@
         }
       };
 
-      // when/if we decide to include this functionality in other versions, we can remove the conditional liquid statement
-      // and migrate the contained code block to customscripts.js
-      {% if page.version.version == 'v2.1' %}
-        if ($(window).width() >= 992) {
-          $('#mysidebar .tier-1').addClass('active--expand');
-        }
-    
-        $(window).on('resize', function() {
-          if ($(window).width() > 992) {
-            $('#mysidebar .tier-1>ul').slideDown(0);
-            adjustMinHeight();
-          } else {
-            $('#mysidebar .tier-1>ul').slideUp(0);
-          }
-        });
-      {% endif %}
-        
-      function adjustMinHeight(duration) {
-        setTimeout(function() {
-          var height = $sidebar.outerHeight();
-          if(height > 475) {
-            $maincontent.animate({ 'min-height' : 625 + (height - 475) }, 200);
-            $contentcol.css({ 'min-height' : 625 + (height - 475) });
-          } else {
-            $maincontent.animate({ 'min-height' : 625 }, 200);
-            $contentcol.css({ 'min-height' : 625 });
-          }
-        }, 200);
-      }
+      $('#mysidebar .tier-1').addClass('active--expand');
 
       function closeVersionSwitcher() {
         $('#version-switcher .tier-1 ul').slideUp();
@@ -60,7 +32,6 @@
 
       $sidebar.navgoco($.extend(navgocoOptions, {
         onToggleAfter: function() {
-          adjustMinHeight();
           if ($(this.el).attr('id') == 'mysidebar' &&
               $('#version-switcher').hasClass('open')) {
             closeVersionSwitcher();
@@ -76,7 +47,6 @@
 
       $sidebar.show();
       $versionSwitcher.show();
-      adjustMinHeight();
     });
   </script>
 

js/customscripts.js

@@ -123,9 +123,9 @@ $(function() {
       $colSidebar.css('bottom', '');
       $versionSwitcher.css({'bottom': '0'});
 
-      var scrolled = $('.col-sidebar').hasClass('col-sidebar--scrolled');
+      var scrolled = $colSidebar.hasClass('col-sidebar--scrolled');
       if ($sidebar.hasClass('nav--collapsed') && scrollTop > 0 && !scrolled) {
-        $('.col-sidebar').addClass('col-sidebar--scrolled');
+        $colSidebar.addClass('col-sidebar--scrolled');
         $('.collapsed-header__pre').slideUp(250);
         sideNavHeight = '40px';
         $sidebar.animate({height: sideNavHeight}, {duration: 250});