Skip to content

Commit 0733e11

Browse files
committed
Separate username/PW from connectstring so it's properly masked in logging
1 parent 351c76a commit 0733e11

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/main/java/org/utplsql/cli/datasource/TestedDataSourceProvider.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ private void setThickOrThinJdbcUrl(HikariDataSource ds ) throws SQLException
4646
{
4747
List<String> errors = new ArrayList<>();
4848
Throwable lastException = null;
49+
50+
ds.setUsername(config.getUser());
51+
ds.setPassword(config.getPassword());
52+
4953
for (ConnectStringPossibility possibility : possibilities) {
5054
ds.setJdbcUrl(possibility.getConnectString(config));
5155
try (Connection con = ds.getConnection()) {
@@ -92,7 +96,7 @@ private void setInitSqlFrom_NLS_LANG(HikariDataSource ds ) {
9296
private static class ThickConnectStringPossibility implements ConnectStringPossibility {
9397
@Override
9498
public String getConnectString(ConnectionConfig config) {
95-
return "jdbc:oracle:oci8:" + config.getConnectString();
99+
return "jdbc:oracle:oci8:@" + config.getConnect();
96100
}
97101

98102
@Override
@@ -104,7 +108,7 @@ public String getMaskedConnectString(ConnectionConfig config) {
104108
private static class ThinConnectStringPossibility implements ConnectStringPossibility {
105109
@Override
106110
public String getConnectString(ConnectionConfig config) {
107-
return "jdbc:oracle:thin:" + config.getConnectString();
111+
return "jdbc:oracle:thin:@" + config.getConnect();
108112
}
109113

110114
@Override

0 commit comments

Comments
 (0)