Skip to content

Potential fix for code scanning alert no. 1: Code injection #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tuxology wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 1: Code injection #1136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/create_destroy_test_vm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@ jobs:
We will notify you when the VM is ready.

- name: Get checkout commit ref and repo
env:
merge_commit_sha: ${{ github.event.pull_request.merge_commit_sha }}
head_ref: ${{ github.event.pull_request.head.ref }}
target_repo: ${{ github.repository }}
pr_repo: ${{ github.event.pull_request.head.repo.full_name }}
run: |

# for context read this https://github.com/Arelle/Arelle/pull/938/files#r1377926250
merge_commit_sha=${{ github.event.pull_request.merge_commit_sha }}
head_ref=${{ github.event.pull_request.head.ref }}
target_repo=${{ github.repository }}
pr_repo=${{ github.event.pull_request.head.repo.full_name }}

CHECKOUT_COMMIT_REF=$([ "$merge_commit_sha" != "" ] && \
echo "$merge_commit_sha" || echo "$head_ref")
Expand Down