Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering project is not working well #197

Open
edimitchel opened this issue Dec 6, 2023 · 4 comments · May be fixed by #348
Open

Filtering project is not working well #197

edimitchel opened this issue Dec 6, 2023 · 4 comments · May be fixed by #348
Assignees
Labels
bug Something isn't working

Comments

@edimitchel
Copy link

edimitchel commented Dec 6, 2023

Environment

Firefox

Reproduction

Go to packages, try to filter with 'x' and see that no package is shown. nevertheless that it exists ipx

Describe the bug

Capture d’écran 2023-12-06 à 01 23 19

We should be able to filter correctly the packages list, and probably not seeking only the name, but also in the description or tags related to the package.

Also, we could show a message when no package match the criteria

Additional context

No response

Logs

No response

@Barbapapazes Barbapapazes self-assigned this Dec 6, 2023
@Barbapapazes Barbapapazes added bug Something isn't working and removed pending triage labels Dec 6, 2023
@Barbapapazes
Copy link
Member

Hello,

Thanks for the issue! Under the hood, we use MiniSearch and I'm not sure to know how I could configure it to achieve this.

I will add the message for empty text.

@lucaong
Copy link

lucaong commented Dec 6, 2023

Hello, MiniSearch author here. Here's a relevant comment: lucaong/minisearch#243 (comment)

@Barbapapazes
Copy link
Member

I will take a look at this to see if it can help:

Perhaps, you need to match in the middle of terms only for the package name, but not for other fields? If so, you can apply the custom processTerm from the example just for the package name, and use the default processor for the other fields.

@shuuji3 shuuji3 linked a pull request Dec 28, 2024 that will close this issue
9 tasks
@shuuji3
Copy link

shuuji3 commented Dec 28, 2024

Hi, thanks to the above custom processTerm example, I think I was able to achieve the correct partial string search for package names by #348. Could you take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants