optimize startup time (disable save prefs on few fields, disable dummy placeholder data in grid to avoid Clear(), adjust GetTargetPlatform method

unitycoder · unitycoder · commit 2ad723a7c677 · 2025-04-24T15:21:12.000+03:00
diff --git a/UnityLauncherPro/MainWindow.xaml b/UnityLauncherPro/MainWindow.xaml
@@ -237,7 +237,8 @@
                             </ContextMenu>
                         </DataGrid.ContextMenu>
 
-                        <!-- sample data for testing -->
+                        <!-- TODO cannot have this enabled, otherwise needs additional .Clear() at start before setting itemsource data -->
+                        <!-- sample data for testing --><!--
                         <local:Project TargetPlatform="win64" GITBranch="Best" Modified="" Title="M dfgh dfghMO" Path="A:/temp" Version="2099.1.2.3" />
                         <local:Project GITBranch="" Modified="" Title="asdgdfg" Path="A:/temp" Version="5.6.7f1"/>
                         <local:Project GITBranch="" Modified="" Title="Mghdfghdf dfghdfgMO" Path="A:/temp" Version="2018.3.13f1"/>
@@ -269,7 +270,7 @@
                         <local:Project GITBranch="" Modified="" Title="MMd fghO" Path="A:/temp" Version="2099.1.2.3"/>
                         <local:Project GITBranch="" Modified="" Title="MMO" Path="A:/temp" Version="2099.1.2.3"/>
                         <local:Project GITBranch="" Modified="" Title="MMdfg hO" Path="A:/temp" Version="2099.1.2.3"/>
-                        <local:Project GITBranch="" Modified="" Title="Md fghMO" Path="A:/temp" Version="2099.1.2.3"/>
+                        <local:Project GITBranch="" Modified="" Title="Md fghMO" Path="A:/temp" Version="2099.1.2.3"/>-->
                     </DataGrid>
 
                     <!-- bottom buttoms row -->
diff --git a/UnityLauncherPro/MainWindow.xaml.cs b/UnityLauncherPro/MainWindow.xaml.cs
@@ -113,8 +113,6 @@ void Init()
             {
                 lblVersion.Content = "Build: " + Version.Stamp;
             }
-
-            CheckCustomIcon();
         }
 
         void Start()
@@ -153,7 +151,7 @@ void Start()
 
             //Console.WriteLine("projectsSource.Count: " + projectsSource.Count);
 
-            gridRecent.Items.Clear();
+            //gridRecent.Items.Clear(); // not needed?
             gridRecent.ItemsSource = projectsSource;
 
             // clear updates grid
@@ -190,6 +188,8 @@ void Start()
 
             if (Settings.Default.disableUnityHubLaunch == true) StartHubPipe();
 
+            CheckCustomIcon();
+
             isInitializing = false;
         } // Start()
 
@@ -2043,8 +2043,10 @@ private void BtnBrowseProjectRootFolder_Click(object sender, RoutedEventArgs e)
 
         private void TxtRootFolderForNewProjects_TextChanged(object sender, TextChangedEventArgs e)
         {
-            Properties.Settings.Default.newProjectsRoot = txtRootFolderForNewProjects.Text;
-            Properties.Settings.Default.Save();
+            if (this.IsActive == false) return; // dont run code on window init
+
+            Settings.Default.newProjectsRoot = txtRootFolderForNewProjects.Text;
+            Settings.Default.Save();
         }
 
 
@@ -2263,8 +2265,8 @@ private void ChkEnableProjectRename_Checked(object sender, RoutedEventArgs e)
         {
             if (this.IsActive == false) return; // dont run code on window init
 
-            Properties.Settings.Default.enableProjectRename = (bool)chkEnableProjectRename.IsChecked;
-            Properties.Settings.Default.Save();
+            Settings.Default.enableProjectRename = (bool)chkEnableProjectRename.IsChecked;
+            Settings.Default.Save();
         }
 
         private void MenuItemKillProcess_Click(object sender, RoutedEventArgs e)
@@ -2666,8 +2668,10 @@ private void MenuStartWebGLServer_Click(object sender, RoutedEventArgs e)
 
         private void TxtWebglRelativePath_TextChanged(object sender, TextChangedEventArgs e)
         {
-            Properties.Settings.Default.webglBuildPath = txtWebglRelativePath.Text;
-            Properties.Settings.Default.Save();
+            if (this.IsActive == false) return; // dont run code on window init
+
+            Settings.Default.webglBuildPath = txtWebglRelativePath.Text;
+            Settings.Default.Save();
         }
 
         private void MenuItemBrowsePersistentDataPath_Click(object sender, RoutedEventArgs e)
@@ -3232,6 +3236,8 @@ private void MenuCreateDesktopShortCut_Click(object sender, RoutedEventArgs e)
 
         private void TxtShortcutBatchFileFolder_TextChanged(object sender, TextChangedEventArgs e)
         {
+            if (this.IsActive == false) return; // dont run code on window init
+
             var folder = ((TextBox)sender).Text;
             if (Directory.Exists(folder))
             {
diff --git a/UnityLauncherPro/Tools.cs b/UnityLauncherPro/Tools.cs
@@ -1493,48 +1493,64 @@ private static string ExtractPlasticBranch(string plasticSelectorPath)
             return null;
         }
 
-
-        //public static Platform GetTargetPlatform(string projectPath)
         static string GetTargetPlatformRaw(string projectPath)
         {
             string results = null;
-            //Platform results = Platform.Unknown;
 
             // get buildtarget from .csproj
             // <UnityBuildTarget>StandaloneWindows64:19</UnityBuildTarget>
             // get main csproj file
             var csproj = Path.Combine(projectPath, "Assembly-CSharp.csproj");
+
             // TODO check projname also, if no assembly-.., NOTE already checked above
-            //var csproj = Path.Combine(projectPath, projectName + ".csproj");
+            // var csproj = Path.Combine(projectPath, projectName + ".csproj");
+
             if (File.Exists(csproj))
             {
-                var csprojtxt = File.ReadAllText(csproj);
-                var csprojsplit = csprojtxt.Split(new[] { "<UnityBuildTarget>" }, StringSplitOptions.None);
-                if (csprojsplit != null && csprojsplit.Length > 1)
+                // Read the file line by line for performance
+                using (var reader = new StreamReader(csproj))
                 {
-                    var endrow = csprojsplit[1].IndexOf(":");
-                    if (endrow > -1)
+                    string line;
+                    while ((line = reader.ReadLine()) != null)
                     {
-                        //Console.WriteLine("build target: " + csprojsplit[1].Substring(0, endrow));
-                        // 5.6 : win32, win64, osx, linux, linux64, ios, android, web, webstreamed, webgl, xboxone, ps4, psp2, wsaplayer, tizen, samsungtv
-                        // 2017: standalone, Win, Win64, OSXUniversal, Linux, Linux64, LinuxUniversal, iOS, Android, Web, WebStreamed, WebGL, XboxOne, PS4, PSP2, WindowsStoreApps, Switch, WiiU, N3DS, tvOS, PSM
-                        // 2018: standalone, Win, Win64, OSXUniversal, Linux, Linux64, LinuxUniversal, iOS, Android, Web, WebStreamed, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, N3DS, tvOS
-                        // 2019: Standalone, Win, Win64, OSXUniversal, Linux64, iOS, Android, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, tvOS
-                        // 2020: Standalone, Win, Win64, OSXUniversal, Linux64, iOS, Android, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, tvOS
-                        // 2021: Standalone, Win, Win64, OSXUniversal, Linux64, iOS, Android, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, tvOS
-                        results = csprojsplit[1].Substring(0, endrow);
-                        //results = (Platform)Enum.Parse(typeof(Platform), csprojsplit[1].Substring(0, endrow));
+                        const string tagStart = "<UnityBuildTarget>";
+                        const string tagEnd = "</UnityBuildTarget>";
+
+                        int startIdx = line.IndexOf(tagStart);
+                        if (startIdx >= 0)
+                        {
+                            int endIdx = line.IndexOf(tagEnd, startIdx);
+                            if (endIdx > startIdx)
+                            {
+                                string inner = line.Substring(startIdx + tagStart.Length, endIdx - startIdx - tagStart.Length);
+                                int colonIndex = inner.IndexOf(':');
+                                if (colonIndex > -1)
+                                {
+                                    //Console.WriteLine("build target: " + inner.Substring(0, colonIndex));
+                                    // 5.6 : win32, win64, osx, linux, linux64, ios, android, web, webstreamed, webgl, xboxone, ps4, psp2, wsaplayer, tizen, samsungtv
+                                    // 2017: standalone, Win, Win64, OSXUniversal, Linux, Linux64, LinuxUniversal, iOS, Android, Web, WebStreamed, WebGL, XboxOne, PS4, PSP2, WindowsStoreApps, Switch, WiiU, N3DS, tvOS, PSM
+                                    // 2018: standalone, Win, Win64, OSXUniversal, Linux, Linux64, LinuxUniversal, iOS, Android, Web, WebStreamed, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, N3DS, tvOS
+                                    // 2019: Standalone, Win, Win64, OSXUniversal, Linux64, iOS, Android, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, tvOS
+                                    // 2020: Standalone, Win, Win64, OSXUniversal, Linux64, iOS, Android, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, tvOS
+                                    // 2021: Standalone, Win, Win64, OSXUniversal, Linux64, iOS, Android, WebGL, XboxOne, PS4, WindowsStoreApps, Switch, tvOS
+                                    results = inner.Substring(0, colonIndex);
+                                    //results = (Platform)Enum.Parse(typeof(Platform), inner.Substring(0, colonIndex));
+                                    break; // we found it, exit early
+                                }
+                            }
+                        }
                     }
                 }
             }
             else
             {
-                //Console.WriteLine("Missing csproj, cannot parse target platform: "+ projectPath);
+                //Console.WriteLine("Missing csproj, cannot parse target platform: " + projectPath);
             }
 
             return results;
         }
 
+
         public static string GetTargetPlatform(string projectPath)
         {
             var rawPlatformName = GetTargetPlatformRaw(projectPath);

Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,6 @@ void Init()`
`113`	`113`	`{`
`114`	`114`	`lblVersion.Content = "Build: " + Version.Stamp;`
`115`	`115`	`}`
`116`		`-`
`117`		`- CheckCustomIcon();`
`118`	`116`	`}`
`119`	`117`
`120`	`118`	`void Start()`
`@@ -153,7 +151,7 @@ void Start()`
`153`	`151`
`154`	`152`	`//Console.WriteLine("projectsSource.Count: " + projectsSource.Count);`
`155`	`153`
`156`		`- gridRecent.Items.Clear();`
	`154`	`+ //gridRecent.Items.Clear(); // not needed?`
`157`	`155`	`gridRecent.ItemsSource = projectsSource;`
`158`	`156`
`159`	`157`	`// clear updates grid`
`@@ -190,6 +188,8 @@ void Start()`
`190`	`188`
`191`	`189`	`if (Settings.Default.disableUnityHubLaunch == true) StartHubPipe();`
`192`	`190`
	`191`	`+ CheckCustomIcon();`
	`192`	`+`
`193`	`193`	`isInitializing = false;`
`194`	`194`	`} // Start()`
`195`	`195`
`@@ -2043,8 +2043,10 @@ private void BtnBrowseProjectRootFolder_Click(object sender, RoutedEventArgs e)`
`2043`	`2043`
`2044`	`2044`	`private void TxtRootFolderForNewProjects_TextChanged(object sender, TextChangedEventArgs e)`
`2045`	`2045`	`{`
`2046`		`- Properties.Settings.Default.newProjectsRoot = txtRootFolderForNewProjects.Text;`
`2047`		`- Properties.Settings.Default.Save();`
	`2046`	`+ if (this.IsActive == false) return; // dont run code on window init`
	`2047`	`+`
	`2048`	`+ Settings.Default.newProjectsRoot = txtRootFolderForNewProjects.Text;`
	`2049`	`+ Settings.Default.Save();`
`2048`	`2050`	`}`
`2049`	`2051`
`2050`	`2052`
`@@ -2263,8 +2265,8 @@ private void ChkEnableProjectRename_Checked(object sender, RoutedEventArgs e)`
`2263`	`2265`	`{`
`2264`	`2266`	`if (this.IsActive == false) return; // dont run code on window init`
`2265`	`2267`
`2266`		`- Properties.Settings.Default.enableProjectRename = (bool)chkEnableProjectRename.IsChecked;`
`2267`		`- Properties.Settings.Default.Save();`
	`2268`	`+ Settings.Default.enableProjectRename = (bool)chkEnableProjectRename.IsChecked;`
	`2269`	`+ Settings.Default.Save();`
`2268`	`2270`	`}`
`2269`	`2271`
`2270`	`2272`	`private void MenuItemKillProcess_Click(object sender, RoutedEventArgs e)`
`@@ -2666,8 +2668,10 @@ private void MenuStartWebGLServer_Click(object sender, RoutedEventArgs e)`
`2666`	`2668`
`2667`	`2669`	`private void TxtWebglRelativePath_TextChanged(object sender, TextChangedEventArgs e)`
`2668`	`2670`	`{`
`2669`		`- Properties.Settings.Default.webglBuildPath = txtWebglRelativePath.Text;`
`2670`		`- Properties.Settings.Default.Save();`
	`2671`	`+ if (this.IsActive == false) return; // dont run code on window init`
	`2672`	`+`
	`2673`	`+ Settings.Default.webglBuildPath = txtWebglRelativePath.Text;`
	`2674`	`+ Settings.Default.Save();`
`2671`	`2675`	`}`
`2672`	`2676`
`2673`	`2677`	`private void MenuItemBrowsePersistentDataPath_Click(object sender, RoutedEventArgs e)`
`@@ -3232,6 +3236,8 @@ private void MenuCreateDesktopShortCut_Click(object sender, RoutedEventArgs e)`
`3232`	`3236`
`3233`	`3237`	`private void TxtShortcutBatchFileFolder_TextChanged(object sender, TextChangedEventArgs e)`
`3234`	`3238`	`{`
	`3239`	`+ if (this.IsActive == false) return; // dont run code on window init`
	`3240`	`+`
`3235`	`3241`	`var folder = ((TextBox)sender).Text;`
`3236`	`3242`	`if (Directory.Exists(folder))`
`3237`	`3243`	`{`