If user is provided but project query is empty, just list projects by the user

Author: ChrisPenner

src/Share/Postgres/Queries.hs

@@ -261,6 +261,22 @@ searchUsersByNameOrHandlePrefix (Query prefix) (Limit limit) = do
 -- The PG.queryListRows accepts strings as web search queries, see
 -- https://www.postgresql.org/docs/current/textsearch-controls.html
 searchProjects :: Maybe UserId -> Maybe UserId -> Query -> Limit -> PG.Transaction e [(Project, UserHandle)]
+-- Don't search with an empty query
+searchProjects _caller Nothing (Query "") _limit = pure []
+searchProjects caller (Just userId) (Query "") limit = do
+  -- If we have a userId filter but no query, just return all the projects owned by that user
+  -- which the caller has access to.
+  PG.queryListRows @(Project PG.:. PG.Only UserHandle)
+    [PG.sql|
+    SELECT p.id, p.owner_user_id, p.slug, p.summary, p.tags, p.private, p.created_at, p.updated_at, owner.handle
+      FROM projects p
+        JOIN users owner ON p.owner_user_id = owner.id
+      WHERE p.owner_user_id = #{userId}
+        AND (NOT p.private OR (#{caller} IS NOT NULL AND EXISTS (SELECT FROM accessible_private_projects WHERE user_id = #{caller} AND project_id = p.id)))
+      ORDER BY p.created_at DESC
+      LIMIT #{limit}
+      |]
+    <&> fmap \(project PG.:. PG.Only handle) -> (project, handle)
 searchProjects caller userIdFilter (Query query) limit = do
   let prefixQuery =
         query

transcripts/share-apis/projects-flow/project-search-with-user.json renamed to transcripts/share-apis/projects-flow/project-search-with-only-user.json

@@ -0,0 +1,15 @@
+{
+  "body": [
+    {
+      "projectRef": "@test/publictestproject",
+      "summary": "test project summary",
+      "tag": "Project",
+      "visibility": "public"
+    }
+  ],
+  "status": [
+    {
+      "status_code": 200
+    }
+  ]
+}

transcripts/share-apis/projects-flow/project-search-with-user-and-project-query.json

@@ -79,7 +79,10 @@ fetch "$transcript_user" GET project-catalog-get '/catalog'
 fetch "$transcript_user" GET project-search '/search?query=test'
 
 # Should filter project search by user if provided a full valid handle:
-fetch "$transcript_user" GET project-search-with-user '/search?query=@test/public'
+fetch "$transcript_user" GET project-search-with-user-and-project-query '/search?query=@test/public'
+
+# Should return all projects in a user if provided a full valid handle, but no project query:
+fetch "$transcript_user" GET project-search-with-only-user '/search?query=@test/'
 
 # Transcript user should not find 'test' user's private project
 fetch "$transcript_user" GET project-search-inaccessible '/search?query=privatetestproject'