Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of groups in convert UFO2 to UFO3 kerning sample implementation #99

Open
jenskutilek opened this issue Nov 20, 2019 · 2 comments
Assignees
Labels
ufo3 UFO 3 issues.

Comments

@jenskutilek
Copy link
Contributor

I wonder if it's intended that the UFO2 to UFO3 kerning conversion sample implementation adds the upgraded kerning group names to the existing groups instead of removing the old groups from the dict. It seems to generate a lot of unnecessary data in groups.plist.

@typesupply typesupply self-assigned this Aug 12, 2020
@typesupply typesupply added the ufo3 UFO 3 issues. label Aug 12, 2020
@madig
Copy link
Contributor

madig commented Dec 16, 2020

Is it maybe to keep the data there for tools that use it?

@typesupply
Copy link
Contributor

Is it maybe to keep the data there for tools that use it?

I think that was more or less my idea. Since any group could be used as a kerning group in <= UFO2, I didn't want to assume that the group no longer served any purpose. In practice, however, this is very confusing. I think the algorithm should get a retainConverted (or something like that) option with the default being False.

@jenskutilek I'm sorry for not commenting on this earlier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ufo3 UFO 3 issues.
Projects
None yet
Development

No branches or pull requests

3 participants