Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: mockredis with connection uri #42

Open
mochic opened this issue Jul 27, 2018 · 3 comments
Open

enhancement: mockredis with connection uri #42

mochic opened this issue Jul 27, 2018 · 3 comments

Comments

@mochic
Copy link

mochic commented Jul 27, 2018

hey

  • really appreciate this extension, it's made my life a lot easier (as is with most flask extensions)
  • mongoengine supports mocking via connection uri: mongomock://...
  • this sort of behavior greatly simplifies switching between application test/dev/prod for some application architectures
  • would you be open to adding this sort of functionality via something like uri: mockredispy://...
  • would be happy to submit a simple pr asap
@mochic mochic changed the title enhancement: mockredis with url enhancement: mockredis with connection uri Jul 27, 2018
@mochic mochic changed the title enhancement: mockredis with connection uri :enhancement: mockredis with connection uri Jul 27, 2018
@mochic mochic changed the title :enhancement: mockredis with connection uri enhancement: mockredis with connection uri Jul 27, 2018
@underyx
Copy link
Owner

underyx commented Feb 24, 2020

Hey @mochic! Apologies for the super late response. This does sound like a great idea and I'd absolutely accept a PR for it. Otherwise, I'll hopefully find some time soon to do it myself.

@mochic
Copy link
Author

mochic commented Feb 28, 2020

@underyx
Literally just got swamped with more work than is typical but I'll try to submit a pr for this (within next couple of days?) if you havent added it in already.

@mochic
Copy link
Author

mochic commented Mar 17, 2020

@underyx kinda bogged down with work stuff and the current crisis in Seattle so...I'll try to get to this soon. Sorry for the delays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants