Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider rounding expression values #123

Open
pdiakumis opened this issue Nov 16, 2023 · 3 comments
Open

Consider rounding expression values #123

pdiakumis opened this issue Nov 16, 2023 · 3 comments
Assignees
@pdiakumis
Labels
bug Something isn't working rpkg Pertaining to the R pkg dev

Comments

@pdiakumis
Copy link
Member

Due to floating-point precision it might be better to round off expression values in the raw expression matrix.
See https://umccr.slack.com/archives/C04F5SMUH8C/p1699878645706829.
@pdiakumis pdiakumis added the bug Something isn't working label Nov 16, 2023
@pdiakumis pdiakumis self-assigned this Nov 16, 2023
@pdiakumis pdiakumis added the rpkg Pertaining to the R pkg dev label Jan 12, 2024
@skanwal
Copy link
Member

skanwal commented Feb 4, 2025

@pdiakumis - can this be closed?

@pdiakumis
Copy link
Member Author

This hasn't been resolved if that's what you're asking?
If you want to close as not planned, go ahead. Still think those floats need to be dealt with accordingly by whoever wants to tackle that part.

@skanwal
Copy link
Member

skanwal commented Feb 4, 2025

Okay - I'll keep this open and plan a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdiakumis pdiakumis

Labels
bug Something isn't working rpkg Pertaining to the R pkg dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skanwal @pdiakumis