From 8e577ca47497d2d20b8788373dede50557b6a3e1 Mon Sep 17 00:00:00 2001
From: techfg <barry@techfg.com>
Date: Thu, 6 Feb 2025 16:17:33 -0800
Subject: [PATCH] chore: modify detection of credentials to use for cypress
 tests (#4580)

* chore: modify detection of credentials to use for cypress tests

* chore: add comment
---
 .github/workflows/ci.yaml           | 10 ++--------
 apps/platform-e2e/cypress.config.ts |  7 +------
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 292f756805..2c9af224ca 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -73,13 +73,13 @@ jobs:
 
       - name: Build and test
         env:
-          UESIO_DEV: "true"
+          UESIO_DEV: "true" # required to ensure packui gets built
         run: npx nx affected -t build test --configuration=ci --parallel=5
 
       - name: Prep for docker image
         id: setDockerSHAs
         env:
-          UESIO_DEV: "true"
+          UESIO_DEV: "true" # required to ensure packui gets built
         run: |
           # We lint/test/build affected but in order to build image, we need to ensure everything
           # is built.  Build anything that hasn't been built yet (takes advantage of nx cache
@@ -207,13 +207,9 @@ jobs:
         run: npm ci
 
       - name: Check formatting
-        env:
-          UESIO_DEV: "true"
         run: npx nx format:check --verbose
 
       - name: Lint
-        env:
-          UESIO_DEV: "true"
         run: npx nx affected -t lint --configuration=ci --parallel=5
 
   typecheck:
@@ -245,8 +241,6 @@ jobs:
         run: npm ci
 
       - name: Typecheck
-        env:
-          UESIO_DEV: "true"
         run: npx nx affected -t typecheck --configuration=ci --parallel=5
 
   update-dev-branch:
diff --git a/apps/platform-e2e/cypress.config.ts b/apps/platform-e2e/cypress.config.ts
index 6576671895..4f9f5dd352 100644
--- a/apps/platform-e2e/cypress.config.ts
+++ b/apps/platform-e2e/cypress.config.ts
@@ -5,13 +5,8 @@ const studioBaseUrl =
   process.env.UESIO_APP_URL || `https://studio.uesio-dev.com:3000`
 const automationUsername = process.env.UESIO_AUTOMATION_USERNAME || "uesio"
 const automationPassword = process.env.UESIO_AUTOMATION_PASSWORD
-const useMockLogin = process.env.UESIO_DEV
+const useMockLogin = !automationPassword
 const inCi = process.env.CI === "true"
-
-if (!useMockLogin && !automationPassword) {
-  throw new Error("UESIO_AUTOMATION_PASSWORD was not provided")
-}
-
 export default defineConfig({
   e2e: {
     ...nxE2EPreset(__filename, {