Skip to content

Commit 416e5b2

Browse files
authored
Merge pull request #18 from uc-cdis/fix/completed_jobs
fix(completed_jobs): increase time to harvest completed jobs
2 parents ba402da + 6c917dd commit 416e5b2

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

handlers/handler.go

+10-2
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ func (handler *SQSHandler) StartServer() error {
6767
glog.Info("The server is started")
6868

6969
go handler.StartMonitoringProcess()
70+
go handler.RemoveCompletedJobsProcess()
7071

7172
return nil
7273

@@ -93,12 +94,19 @@ func (handler *SQSHandler) StartMonitoringProcess() {
9394
handler.MonitoredJobs = nextMonitoredJobs
9495
handler.Mu.Unlock()
9596

96-
RemoveCompletedJobs()
97-
9897
time.Sleep(30 * time.Second)
9998
}
10099
}
101100

101+
// RemoveCompletedJobsProcess starts the process to remove completed jobs
102+
func (handler *SQSHandler) RemoveCompletedJobsProcess() {
103+
for {
104+
time.Sleep(300 * time.Second)
105+
glog.Info("Start to remove completed jobs")
106+
RemoveCompletedJobs()
107+
}
108+
}
109+
102110
// ShutdownServer shutdowns a server
103111
func (handler *SQSHandler) ShutdownServer() error {
104112
fmt.Println("Shutdown the server")

handlers/jobs.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func GetNumberRunningJobs() int {
153153
nRunningJobs := 0
154154
for i := 0; i < len(jobs.JobInfo); i++ {
155155
job := jobs.JobInfo[i]
156-
if job.Status == "Running" {
156+
if job.Status == "Running" || job.Status == "Unknown" {
157157
nRunningJobs++
158158
}
159159
}

0 commit comments

Comments
 (0)