fix use fractional height value (#1677)

mfshao · web-flow · commit 61992c98fed3 · 2025-02-27T10:57:13.000-06:00
diff --git a/src/components/layout/ExternalFooter.tsx b/src/components/layout/ExternalFooter.tsx
@@ -15,7 +15,7 @@ const ExternalFooter: React.FC<ExternalFooterProps> = (props: ExternalFooterProp
       style={{ display: 'block', width: '100%', height: elementHeight }}
       onLoad={
         () => setElementHeight(
-          `${document.getElementById('externalFooter').contentWindow.document.body.scrollHeight}px`,
+          `${document.getElementById('externalFooter').contentWindow.document.body.getBoundingClientRect().height}px`,
         )
       }
     />

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ const ExternalFooter: React.FC<ExternalFooterProps> = (props: ExternalFooterProp`
`15`	`15`	`style={{ display: 'block', width: '100%', height: elementHeight }}`
`16`	`16`	`onLoad={`
`17`	`17`	`() => setElementHeight(`
`18`		- `${document.getElementById('externalFooter').contentWindow.document.body.scrollHeight}px`,
	`18`	+ `${document.getElementById('externalFooter').contentWindow.document.body.getBoundingClientRect().height}px`,
`19`	`19`	`)`
`20`	`20`	`}`
`21`	`21`	`/>`