Consolidate NUnit3TestAdapter to 5.0.0 + address minor analyzer issues (#871)

Author: louis-z

NGitLab.Mock.Tests/NGitLab.Mock.Tests.csproj

@@ -13,7 +13,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="5.0.0" />
     <PackageReference Include="Verify.NUnit" Version="28.13.0" />
   </ItemGroup>
 </Project>

NGitLab/IGitLabClient.cs

@@ -101,9 +101,9 @@ public interface IGitLabClient
 
     IProtectedTagClient GetProtectedTagClient(ProjectId projectId);
 
-    public ISearchClient GetGroupSearchClient(GroupId groupId);
+    ISearchClient GetGroupSearchClient(GroupId groupId);
 
-    public ISearchClient GetProjectSearchClient(ProjectId projectId);
+    ISearchClient GetProjectSearchClient(ProjectId projectId);
 
-    public IGroupHooksClient GetGroupHooksClient(GroupId groupId);
+    IGroupHooksClient GetGroupHooksClient(GroupId groupId);
 }

NGitLab/IUserClient.cs

@@ -33,7 +33,7 @@ public interface IUserClient
     /// <param name="tokenRequest">info required to create the token</param>
     /// <param name="cancellationToken">Optional cancellation token.</param>
     /// <returns>The new impersonation token.</returns>
-    public Task<UserToken> CreateTokenAsync(UserTokenCreate tokenRequest, CancellationToken cancellationToken = default);
+    Task<UserToken> CreateTokenAsync(UserTokenCreate tokenRequest, CancellationToken cancellationToken = default);
 
     /// <inheritdoc cref="CreateTokenAsync(UserTokenCreate, CancellationToken)"/>>
     UserToken CreateToken(UserTokenCreate tokenRequest);

NGitLab/Impl/IGitDiffChangeCounter.cs

@@ -4,5 +4,5 @@ namespace NGitLab.Impl;
 
 public interface IGitDiffChangeCounter
 {
-    public DiffStats Compute(MergeRequestChange mergeRequestChange);
+    DiffStats Compute(MergeRequestChange mergeRequestChange);
 }