Skip to content

Commit 3eca5d0

Browse files
Upgrade probot
#86
1 parent a4dd7ea commit 3eca5d0

File tree

6 files changed

+451
-220
lines changed

6 files changed

+451
-220
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
node_modules
22
npm-debug.log
3-
*.pem
3+
./*.pem
4+
!__tests__/__fixtures__/mock-cert.pem
45
.env
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
-----BEGIN RSA PRIVATE KEY-----
2+
MIIEowIBAAKCAQEAli7V49NdZe+XYC1pLaHM0te8kiDmZBJ1u2HJHN8GdbROB6NO
3+
VpC3xK7NxQn6xpvZ9ux20NvcDvGle+DOptZztBH+np6h2jZQ1/kD1yG1eQvVH4th
4+
/9oqHuIjmIfO8lIe4Hyd5Fw5xHkGqVETTGR+0c7kdZIlHmkOregUGtMYZRUi4YG+
5+
q0w+uFemiHpGKXbeCIAvkq7aIkisEzvPWfSyYdA6WJHpxFk7tD7D8VkzABLVRHCq
6+
AuyqPG39BhGZcGLXx5rGK56kDBJkyTR1t3DkHpwX+JKNG5UYNwOG4LcQj1fteeta
7+
TdkYUMjIyWbanlMYyC+dq7B5fe7el99jXQ1gXwIDAQABAoIBADKfiPOpzKLOtzzx
8+
MbHzB0LO+75aHq7+1faayJrVxqyoYWELuB1P3NIMhknzyjdmU3t7S7WtVqkm5Twz
9+
lBUC1q+NHUHEgRQ4GNokExpSP4SU63sdlaQTmv0cBxmkNarS6ZuMBgDy4XoLvaYX
10+
MSUf/uukDLhg0ehFS3BteVFtdJyllhDdTenF1Nb1rAeN4egt8XLsE5NQDr1szFEG
11+
xH5lb+8EDtzgsGpeIddWR64xP0lDIKSZWst/toYKWiwjaY9uZCfAhvYQ1RsO7L/t
12+
sERmpYgh+rAZUh/Lr98EI8BPSPhzFcSHmtqzzejvC5zrZPHcUimz0CGA3YBiLoJX
13+
V1OrxmECgYEAxkd8gpmVP+LEWB3lqpSvJaXcGkbzcDb9m0OPzHUAJDZtiIIf0UmO
14+
nvL68/mzbCHSj+yFjZeG1rsrAVrOzrfDCuXjAv+JkEtEx0DIevU1u60lGnevOeky
15+
r8Be7pmymFB9/gzQAd5ezIlTv/COgoO986a3h1yfhzrrzbqSiivw308CgYEAwecI
16+
aZZwqH3GifR+0+Z1B48cezA5tC8LZt5yObGzUfxKTWy30d7lxe9N59t0KUVt/QL5
17+
qVkd7mqGzsUMyxUN2U2HVnFTWfUFMhkn/OnCnayhILs8UlCTD2Xxoy1KbQH/9FIr
18+
xf0pbMNJLXeGfyRt/8H+BzSZKBw9opJBWE4gqfECgYBp9FdvvryHuBkt8UQCRJPX
19+
rWsRy6pY47nf11mnazpZH5Cmqspv3zvMapF6AIxFk0leyYiQolFWvAv+HFV5F6+t
20+
Si1mM8GCDwbA5zh6pEBDewHhw+UqMBh63HSeUhmi1RiOwrAA36CO8i+D2Pt+eQHv
21+
ir52IiPJcs4BUNrv5Q1BdwKBgBHgVNw3LGe8QMOTMOYkRwHNZdjNl2RPOgPf2jQL
22+
d/bFBayhq0jD/fcDmvEXQFxVtFAxKAc+2g2S8J67d/R5Gm/AQAvuIrsWZcY6n38n
23+
pfOXaLt1x5fnKcevpFlg4Y2vM4O416RHNLx8PJDehh3Oo/2CSwMrDDuwbtZAGZok
24+
icphAoGBAI74Tisfn+aeCZMrO8KxaWS5r2CD1KVzddEMRKlJvSKTY+dOCtJ+XKj1
25+
OsZdcDvDC5GtgcywHsYeOWHldgDWY1S8Z/PUo4eK9qBXYBXp3JEZQ1dqzFdz+Txi
26+
rBn2WsFLsxV9j2/ugm0PqWVBcU2bPUCwvaRu3SOms2teaLwGCkhr
27+
-----END RSA PRIVATE KEY-----

__tests__/index.js

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,16 @@
66

77
/* eslint-env jest */
88

9+
const fs = require('fs');
10+
const path = require('path');
911
const nock = require('nock');
1012
const mergePRApp = require('../index.js');
1113
const {Probot} = require('probot');
14+
15+
const MOCK_CERT_PATH = path.resolve(__dirname, '__fixtures__/mock-cert.pem');
16+
// mock cert copied from copied from:
17+
// https://github.com/probot/create-probot-app/blob/de9078d/templates/basic-js/test/fixtures/mock-cert.pem
18+
const MOCK_CERT = fs.readFileSync(MOCK_CERT_PATH, 'utf-8');
1219
const fixtures = {
1320
listCommits: require('./__fixtures__/listCommits.js'),
1421
payload: require('./__fixtures__/issue_comment.created.js'),
@@ -21,11 +28,12 @@ describe('probot-app-merge-pr', () => {
2128
let probot;
2229

2330
beforeEach(() => {
24-
probot = new Probot({});
25-
const app = probot.load(mergePRApp);
31+
probot = new Probot({
32+
id: 123,
33+
cert: MOCK_CERT,
34+
});
2635

27-
// just return a test token
28-
app.app = () => 'test';
36+
probot.load(mergePRApp);
2937
});
3038

3139
test('merges the PR with commit authors as co-authors', async () => {
@@ -39,7 +47,10 @@ describe('probot-app-merge-pr', () => {
3947

4048
const mergeRequest = new Promise(resolve => {
4149
nock('https://api.github.com')
42-
.put('/repos/fusionjs/test-repo/pulls/1/merge', resolve)
50+
.put('/repos/fusionjs/test-repo/pulls/1/merge', body => {
51+
resolve(body);
52+
return true;
53+
})
4354
.reply(200);
4455
});
4556

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ module.exports = robot => {
1717
}
1818

1919
const {github} = context;
20-
const permissions = await github.repos.reviewUserPermissionLevel(
20+
const permissions = await github.repos.getCollaboratorPermissionLevel(
2121
context.repo({
2222
username: user.login,
2323
}),
@@ -46,7 +46,7 @@ module.exports = robot => {
4646
const authorTrailerSet = await github.pullRequests
4747
.listCommits(
4848
context.repo({
49-
number: issue.number,
49+
pull_number: issue.number,
5050
}),
5151
)
5252
.then(res =>
@@ -68,7 +68,7 @@ module.exports = robot => {
6868

6969
await github.pullRequests.merge(
7070
context.repo({
71-
number: issue.number,
71+
pull_number: issue.number,
7272
commit_title: issue.title,
7373
commit_message,
7474
merge_method,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"fix": "eslint . --fix"
1414
},
1515
"dependencies": {
16-
"probot": "7.5.0"
16+
"probot": "^9.2.10"
1717
},
1818
"devDependencies": {
1919
"eslint": "5.14.1",

0 commit comments

Comments
 (0)