Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock Origin for Edge #890

Closed
Nikita34196 opened this issue Feb 10, 2020 · 32 comments
Closed

uBlock Origin for Edge #890

Nikita34196 opened this issue Feb 10, 2020 · 32 comments
Labels
Edge specific to Edge external issue involving an external factor fixed issue has been addressed

Comments

@Nikita34196
Copy link

Hello. why are there no updates for Microsoft edge? In the store edge addons version 1.23. I wrote to the official addon development page for Edge but received no response.

@uBlock-user uBlock-user changed the title uBlockOrigin For edge chromium uBlock Origin for Edge Feb 10, 2020
@uBlock-user uBlock-user added the Edge specific to Edge label Feb 10, 2020
@uBlock-user
Copy link
Contributor

@uBlock-user uBlock-user added the external issue involving an external factor label Feb 10, 2020
@mapx-
Copy link
Contributor

mapx- commented Feb 10, 2020

if it's about 1.23 => edge chromium version and not the outdated nikrolls's version for old edge

L.E. ok you linked to some comment, however edge chromium can use directly chrome store

@uBlock-user
Copy link
Contributor

uBlock-user commented Feb 10, 2020

Old Edge has already been deprecated since last year, so this is about the Chromium fork with Edge branding in MS Store.

however edge chromium can use directly chrome store

somehow it's not pulling the latest version from Chrome Store, this is something @nikrolls needs to investigate,

@gorhill
Copy link
Member

gorhill commented Feb 10, 2020

I think he needs to install directly from Chrome store -- Microsoft used to pull the extension from the Chrome store but they stopped doing this and have been asking for maintainers to now take over publishing in the Edge store. I can't publish in the Microsoft store.

@Nikita34196
Copy link
Author

@gorhill why can't you publish? as far as I know there can be published as for chrome unchanged.

@gorhill
Copy link
Member

gorhill commented Feb 10, 2020

I don't have Windows (so I can't test uBO in Edge), and I don't have a developer account with Microsoft.

@Nikita34196
Copy link
Author

I have a developer account. if you want I can give you it for publication. I can try to publish the latest version myself.

@gorhill
Copy link
Member

gorhill commented Feb 10, 2020

Given the issues with the current publication, I rather no longer rely on someone else publishing for me. So for now it's install from Chrome store, or wait until the day I published myself in the Microsoft store.

@Nikita34196
Copy link
Author

@gorhill Thank you. I think at this stage I will install from the store chrome. but in the future, I'd like you to publish an extension in the edge store.

@uBlock-user uBlock-user added the fixed issue has been addressed label Feb 10, 2020
@RespectIsEverything
Copy link

I don't have Windows (so I can't test uBO in Edge), and I don't have a developer account with Microsoft.

Edge Chromium is also presently available on MacOS. Linux distributions on the horizon.

Nik Rolls isn't actively maintaining the port. It's also unknown what steps would have to be taken in order to reclaim the name.

Looking forward to the day you do decide to publish in the Microsoft Store. Thanks!

@RespectIsEverything
Copy link

I don't have Windows (so I can't test uBO in Edge), and I don't have a developer account with Microsoft.

Edgium is on Mac too. So can be tested there. Linux port also on the way.

If it's a financial issue, Microsoft would likely give you a free account and licenses especially given the popularity of uBO.

Twitter: @MSEdgeDev

@rishavs
Copy link

rishavs commented Apr 7, 2020

@gorhill , can you not test this on macOS itself?

@Hrxn
Copy link

Hrxn commented Apr 10, 2020

Seems to have the latest stable for me...

https://microsoftedge.microsoft.com/addons/detail/odfafepnkmbhccpbejgmiehpchacaeak

Does this mean the extension is pulled automatically again?

@gorhill
Copy link
Member

gorhill commented Apr 10, 2020

Link added to https://github.com/gorhill/uBlock/releases/tag/1.26.0.

@gwarser
Copy link

gwarser commented Apr 15, 2020

This is kept up-to-date with the latest version on the Chrome Web Store.

@nikrolls are you doing this manually? Or MS is again pulling extensions from Chrome Store?

@gwarser
Copy link

gwarser commented Apr 15, 2020

@gorhill readme should be fixed https://github.com/gorhill/uBlock#microsoft-edge

Link to MS store corrected, and note about issues removed.

I don't know what to answer: https://www.reddit.com/r/uBlockOrigin/comments/futlyj/ublock_origin_1260_is_out/fnhmzag/

@nicole-ashley
Copy link

nicole-ashley commented Apr 15, 2020

@gwarser I'm doing this manually. I have looked into automating it but it may be challenging with the (understandable) security measures on Microsoft's partner portal to write some kind of browser automation. Ideally they would release an API like Chrome's store but that doesn't exist yet.

I do understand people's doubts considering my track record of life getting in the way of keeping things up to date. The good news is that the process is now super easy: login, drag & drop the same package already built for Chromium, and submit. It takes 5 minutes max, versus the very time consuming merge, test, debug, package, flight, submit process for the previous Edge. I've also got notifications set up for every release so I don't miss anything.

I am also not intending to hijack or keep ownership of anything. I'm continuing to do this because it maintains the discoverability for Edge users and keeps users who have already installed uBlock from the Microsoft Store up to date, but I have no ego involved in being the one who maintains it. If @gorhill prefers to take this over, considering that this new browser is identical in terms of extension compatibility with Chromium, and can also be tested on Mac (and soon Linux), I would totally understand and do everything possible to facilitate that. We would just need to talk to Microsoft about how to move the extension to a different account, as this is not a common process for them.

@kq01526
Copy link

kq01526 commented Dec 23, 2021

Hi @gorhill ,

Are there any news on this one?

Looks like @nikrolls mentioned he would be willing to hand over the MS Store entry (see previous post).

MS Edge has now also been made available for Linux and macOS in the meantime.

It would be good if the MS Store version would be maintained by the upstream dev.

@gwarser
Copy link

gwarser commented Dec 23, 2021

@kq01526
Copy link

kq01526 commented Dec 23, 2021

@gwarser But not by the original developer of uBlock Origin ( which would be @gorhill ).

Instead, the version on the MS Edge Store is being updated by @nikrolls (who is not the original developer of uBlock Origin as far as it seems).

@nicole-ashley
Copy link

@kq01526 The code is identical. The Chromium package is automatically downloaded from the GitHub release and uploaded to Microsoft completely opaquely.

Currently there is no API for Microsoft like I understand is used for the Chrome store submission. An API is in progress with Microsoft. I suspect this may be a preference for taking over store submission from me, to fit in with existing automation.

Then there is the technical issue of moving the ownership of the Store listing between developers. Historically this wasn't possible with Microsoft, and I can't see any documentation for it now (though it may or may not be available on request).

@kq01526
Copy link

kq01526 commented Dec 23, 2021

Hi @nikrolls ,

Thanks for chiming in on this, this is appreciated.

Assuming a direct transfer of the ownership is not possible, then:

What would happen if you would delete the extension from the MS Edge Store so that @gorhill can re-create it?

There is a Microsoft contact email address listed in the following blog post:

Maybe they can help with the transfer?

PS: It's not meant to downplay your current efforts, it's just meant to be a constructive discussion about how to get the ownership of the MS Edge Store version aligned (also considering that you also seem to think that handing it over to @gorhill would make sense).

@nicole-ashley
Copy link

If we were to delete the listing, then the hundreds of thousands of users who have it installed will be stranded on that last version and will likely not even know they need to uninstall and switch to the new one (and would have to do a manual data transfer).

I have contacts in Microsoft and the Edge team who I can reach out to for checking feasibility of ownership transfer if @gorhill is at a point where he'd like to do this. No strong feelings on my end either way 🙂

@gwarser
Copy link

gwarser commented Jul 3, 2022

@nicole-ashley ping! 1.43.0 not released after three weeks.

@nicole-ashley
Copy link

Apologies - busiest couple of months in a long time for me.

There seems to be an issue with the Store at the moment. I tried this morning and this evening. I'll try again tomorrow and file a case with them if it's not working.
image

It also appears that the API for submitting extension updates is now available. Hard to tell for sure based on the wording in the documentation if it's fully functional, but I'll have a play and if it's usable then it should be trivial to fully automate this release process with an Azure function.

@nicole-ashley
Copy link

nicole-ashley commented Jul 14, 2022

@gwarser OK, everything is now fully automated. Within an hour of a new Chromium release going public (ie, a release with a chromium asset having the prerelease flag turned off), the package will be automatically uploaded to the Edge Addons Store and submitted for review. If a newer release comes out before review has started, the package for review will be replaced with this newest version.

I get notified directly on my phone whenever this is triggered with the status (success or error, and why).

This latest submission has been made entirely through this automation and was successful (ie, successfully in review phase).

@gwarser
Copy link

gwarser commented Mar 15, 2023

@nicole-ashley something stuck on 1.47.2

@gorhill
Copy link
Member

gorhill commented Nov 8, 2023

@nicole-ashley I've enrolled as a Microsoft Partner and I got accepted as a "Microsoft Edge extension developer", so I guess I am all setup be able to publish extensions?

I can now test uBO in Microsoft Edge since it is now available on linux, so if you still want to transfer ownership of uBlock Origin, I guess I am now ready for this.

Currently I think there is an issue with uBO in MSEdge store, and it's probably my fault, as I mistakenly created a stable release of uBO with the wrong version number, I had to delete the published release shortly after I realized my mistake, and maybe this broke the script copying from GitHub.

@nicole-ashley
Copy link

@gorhill I'll see what I can do. I think there were restrictions regarding republishing the same version number, but it's been a while and that may have changed by now. I can also contact Microsoft about transferring ownership.

@gwarser
Copy link

gwarser commented Jun 7, 2024

Stuck again on Version 1.57.2.

@marcussacana
Copy link

Stuck again on Version 1.57.2.

I think may be due manifest v2

@gwarser
Copy link

gwarser commented Aug 7, 2024

Jumped straight to 1.59.0 yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edge specific to Edge external issue involving an external factor fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

12 participants