Skip to content

Commit 530a811

Browse files
committed
Updated rubocop, fixed linting issues
1 parent cba9dba commit 530a811

File tree

5 files changed

+7
-22
lines changed

5 files changed

+7
-22
lines changed

lib/typesense/client.rb

+1-7
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22

33
module Typesense
44
class Client
5-
attr_reader :configuration
6-
attr_reader :collections
7-
attr_reader :aliases
8-
attr_reader :keys
9-
attr_reader :debug
10-
attr_reader :health
11-
attr_reader :metrics
5+
attr_reader :configuration, :collections, :aliases, :keys, :debug, :health, :metrics
126

137
def initialize(options = {})
148
@configuration = Configuration.new(options)

lib/typesense/collection.rb

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
module Typesense
44
class Collection
5-
attr_reader :documents
6-
attr_reader :overrides
5+
attr_reader :documents, :overrides
76

87
def initialize(name, api_call)
98
@name = name

lib/typesense/configuration.rb

+1-9
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,7 @@
22

33
module Typesense
44
class Configuration
5-
attr_accessor :nodes
6-
attr_accessor :nearest_node
7-
attr_accessor :connection_timeout_seconds
8-
attr_accessor :healthcheck_interval_seconds
9-
attr_accessor :num_retries
10-
attr_accessor :retry_interval_seconds
11-
attr_accessor :api_key
12-
attr_accessor :logger
13-
attr_accessor :log_level
5+
attr_accessor :nodes, :nearest_node, :connection_timeout_seconds, :healthcheck_interval_seconds, :num_retries, :retry_interval_seconds, :api_key, :logger, :log_level
146

157
def initialize(options = {})
168
@nodes = options[:nodes] || []

spec/typesense/aliases_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@
3232
'Content-Type' => 'application/json'
3333
})
3434
.to_return(status: 200,
35-
body: JSON.dump(['collection_name' => 'books_january']),
35+
body: JSON.dump([{ 'collection_name' => 'books_january' }]),
3636
headers: {
3737
'Content-Type': 'application/json'
3838
})
3939

4040
result = aliases.retrieve
4141

42-
expect(result).to eq(['collection_name' => 'books_january'])
42+
expect(result).to eq([{ 'collection_name' => 'books_january' }])
4343
end
4444
end
4545

typesense.gemspec

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ Gem::Specification.new do |spec|
2828
spec.add_development_dependency 'pry-byebug', '~> 3.9'
2929
spec.add_development_dependency 'rake', '~> 13.0'
3030
spec.add_development_dependency 'rspec', '~> 3.9'
31-
spec.add_development_dependency 'rspec-legacy_formatters', '~> 1.0' # For codecov formatter
3231
spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4'
33-
spec.add_development_dependency 'rubocop', '~> 0.83'
32+
spec.add_development_dependency 'rspec-legacy_formatters', '~> 1.0' # For codecov formatter
33+
spec.add_development_dependency 'rubocop', '~> 0.88'
3434
spec.add_development_dependency 'rubocop-rspec', '~> 1.39'
3535
spec.add_development_dependency 'simplecov', '~> 0.18'
3636
spec.add_development_dependency 'timecop', '~> 0.9'

0 commit comments

Comments
 (0)