Merge pull request #112 from tjjfvi/patch-2

robertt · web-flow · commit 52e8ac7bc390 · 2021-02-16T23:14:43.000Z
Fix bug in escapeCode re 5 backticks
diff --git a/src/modules/twoslash.ts b/src/modules/twoslash.ts
@@ -11,7 +11,7 @@ const CODEBLOCK = '```';
 // bad. It doesn't properly handle escaping back ticks, so we instead insert zero width spaces
 // so that users cannot escape our code block.
 function escapeCode(code: string) {
-	return code.replace(/```/g, '`\u200B`\u200B`');
+	return code.replace(/`(?=`)/g, '`\u200B');
 }
 
 export class TwoslashModule extends Module {

Original file line number	Diff line number	Diff line change
@@ -11,7 +11,7 @@ const CODEBLOCK = '```';
`11`	`11`	`// bad. It doesn't properly handle escaping back ticks, so we instead insert zero width spaces`
`12`	`12`	`// so that users cannot escape our code block.`
`13`	`13`	`function escapeCode(code: string) {`
`14`		- return code.replace(/```/g, '`\u200B`\u200B`');
	`14`	+ return code.replace(/`(?=`)/g, '`\u200B');
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`export class TwoslashModule extends Module {`