Spreaded anys should satisfy all required properties

Author: RyanCavanaugh

src/compiler/checker.ts

@@ -6830,6 +6830,7 @@ namespace ts {
                     nameTable[prop.name] = true;
                 }
             }
+            return type;
         }
 
         /// Returns the type JSX.IntrinsicElements. May return `unknownType` if that type is not present.
@@ -7101,24 +7102,28 @@ namespace ts {
             // Process this array in right-to-left order so we know which
             // attributes (mostly from spreads) are being overwritten and
             // thus should have their types ignored
+            let sawSpreadedAny = false;
             for (let i = node.attributes.length - 1; i >= 0; i--) {
                 if (node.attributes[i].kind === SyntaxKind.JsxAttribute) {
                     checkJsxAttribute(<JsxAttribute>(node.attributes[i]), targetAttributesType, nameTable);
                 }
                 else {
                     Debug.assert(node.attributes[i].kind === SyntaxKind.JsxSpreadAttribute);
-                    checkJsxSpreadAttribute(<JsxSpreadAttribute>(node.attributes[i]), targetAttributesType, nameTable);
+                    let spreadType = checkJsxSpreadAttribute(<JsxSpreadAttribute>(node.attributes[i]), targetAttributesType, nameTable);
+                    if(isTypeAny(spreadType)) {
+                        sawSpreadedAny = true;
+                    }
                 }
             }
 
-            // Check that all required properties have been provided
-            if (targetAttributesType) {
+            // Check that all required properties have been provided. If an 'any'
+            // was spreaded in, though, assume that it provided all required properties
+            if (targetAttributesType && !sawSpreadedAny) {
                 let targetProperties = getPropertiesOfType(targetAttributesType);
                 for (let i = 0; i < targetProperties.length; i++) {
                     if (!(targetProperties[i].flags & SymbolFlags.Optional) &&
                         nameTable[targetProperties[i].name] === undefined) {
 
-                        console.log('oops?');
                         error(node, Diagnostics.Property_0_is_missing_in_type_1, targetProperties[i].name, typeToString(targetAttributesType));
                     }
                 }

tests/baselines/reference/tsxAttributeResolution8.js

@@ -0,0 +1,16 @@
+//// [tsxAttributeResolution8.tsx]
+declare module JSX {
+	interface Element { }
+	interface IntrinsicElements {
+		test1: {x: string};
+	}
+}
+
+var x: any;
+// Should be OK
+<test1 {...x} />
+
+//// [tsxAttributeResolution8.jsx]
+var x;
+// Should be OK
+<test1 {...x}/>;

tests/baselines/reference/tsxAttributeResolution8.symbols

@@ -0,0 +1,23 @@
+=== tests/cases/conformance/jsx/tsxAttributeResolution8.tsx ===
+declare module JSX {
+>JSX : Symbol(JSX, Decl(tsxAttributeResolution8.tsx, 0, 0))
+
+	interface Element { }
+>Element : Symbol(Element, Decl(tsxAttributeResolution8.tsx, 0, 20))
+
+	interface IntrinsicElements {
+>IntrinsicElements : Symbol(IntrinsicElements, Decl(tsxAttributeResolution8.tsx, 1, 22))
+
+		test1: {x: string};
+>test1 : Symbol(test1, Decl(tsxAttributeResolution8.tsx, 2, 30))
+>x : Symbol(x, Decl(tsxAttributeResolution8.tsx, 3, 10))
+	}
+}
+
+var x: any;
+>x : Symbol(x, Decl(tsxAttributeResolution8.tsx, 7, 3))
+
+// Should be OK
+<test1 {...x} />
+>test1 : Symbol(JSX.IntrinsicElements.test1, Decl(tsxAttributeResolution8.tsx, 2, 30))
+

tests/baselines/reference/tsxAttributeResolution8.types

@@ -0,0 +1,25 @@
+=== tests/cases/conformance/jsx/tsxAttributeResolution8.tsx ===
+declare module JSX {
+>JSX : any
+
+	interface Element { }
+>Element : Element
+
+	interface IntrinsicElements {
+>IntrinsicElements : IntrinsicElements
+
+		test1: {x: string};
+>test1 : { x: string; }
+>x : string
+	}
+}
+
+var x: any;
+>x : any
+
+// Should be OK
+<test1 {...x} />
+><test1 {...x} /> : JSX.Element
+>test1 : any
+>x : any
+

tests/cases/conformance/jsx/tsxAttributeResolution8.tsx

@@ -0,0 +1,12 @@
+//@filename: file.tsx
+//@jsx: preserve
+declare module JSX {
+	interface Element { }
+	interface IntrinsicElements {
+		test1: {x: string};
+	}
+}
+
+var x: any;
+// Should be OK
+<test1 {...x} />