Release 1.15.0 #668

ashawley · 2020-06-04T01:30:59Z

@non @ashawley once this is in, what do you think about releasing 1.15.0? According to #540 it was supposed to come shortly after 1.14.1. It'd be great to get it out for the improved dotty usability from finally getting rid of the ambiguous implicit error due to BooleanOperators.

ashawley · 2020-06-04T18:42:45Z

I agree we should release 1.15.0.

I've worked on applying the 1.15.0 label to open issues, so we can track progress and the remaining effort:

https://github.com/typelevel/scalacheck/milestone/10

smarter · 2020-07-31T17:52:25Z

How critical are the remaining issues in the 1.15.0 milestone? Could some of them be moved to a future milestone to release 1.15.0 faster ?

larsrh · 2020-08-01T09:07:39Z

Would be much appreciated. Happy to volunteer the time to upgrade the Typelevel ecosystem.

SethTisue · 2020-09-21T00:34:51Z

@ashawley are you around and interested in helping push this forward? (fsvo "helping")

ashawley · 2020-09-22T14:39:44Z

I should have free time soon to contribute to getting a release out here. Sorry for the delay.

SethTisue · 2020-10-08T00:54:54Z

note that one possibility would be to just close our eyes, roll whatever we have and call it 1.15.0-M1 (or 1.15.0-RC1), and then work towards 1.15.0 final after

thought prompted because I just hit "ambiguous implicit error due to BooleanOperators" myself today over at scala/scala-parallel-collections#113, so now I know what y'all are talking about there :-)

non · 2020-10-10T00:07:18Z

@SethTisue i'll do that this weekend

non · 2020-10-11T03:06:53Z

@SethTisue So, the Dotty build is blocking the release. Specifically, it appears it didn't build javadoc jars, which Sonatype checks for when validating the release. Here the publish output from Dotty:

[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.pom.asc
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1-sources.jar.asc
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.jar
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.pom
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1.jar.asc
[info]  published scalacheck_0.24 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_0.24/1.15.0-M1/scalacheck_0.24-1.15.0-M1-sources.jar

And here's Scala 2.12 (JVM):

[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-javadoc.jar.asc                                                          
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.pom.asc                                                                  
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-sources.jar.asc                                                          
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.jar                                                                      
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.pom                                                                      
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-javadoc.jar                                                              
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1.jar.asc                                                                  
[info]  published scalacheck_2.12 to https://oss.sonatype.org/service/local/staging/deploy/maven2/org/scalacheck/scalacheck_2.12/1.15.0-M1/scalacheck_2.12-1.15.0-M1-sources.jar

As you can see Dotty only published 6 files while 2.12 published 8.

I don't know a lot about how Dotty publishes. Is this expected? Is there some other SBT command I need to run for Dotty?

EDIT: I ran release.sh publishSigned which runs IS_RELEASE="true" sbt "+ jvm/publishSigned" (among other commands).

smarter · 2020-10-11T03:10:21Z

This comes from your sbt build:

scalacheck/build.sbt

Lines 170 to 174 in b296397

    
           publishArtifact in (Compile, packageDoc) := { 
        
             // dotty-doc defect https://github.com/lampepfl/dotty/issues/7326 
        
             !isDotty.value // ==> true 
        
             // else ==> false 
        
           },

The usual workaround to keep sonatype happy is to still publish a doc jar but leave it empty, this is accomplished by having in your sbt build:

sources in (Compile, doc) := Seq()

except here you only want to do it for dotty so you probably want:

sources in (Compile, doc) := {
  if (isDotty.value) then Seq() else (sources in (Compile, doc)).value
}

non · 2020-10-11T03:11:34Z

@smarter Thanks!

smarter · 2020-10-11T03:15:38Z

You could also turn off the dotty build for now: the scalacheck build is at version 0.24.0-RC1 so it's way too old to be useful currently anyway. You could try bumping it to 0.27.0-RC1 but that might require porting some commits from the version of scalacheck in our community build: https://github.com/dotty-staging/scalacheck/commits/a715860a25ad6d2c6e1ae17e8baa13ded427cdf0

non · 2020-10-11T03:21:32Z

@smarter I'll try with what I have since it's currently on and already running. If this build fails, I'll turn it off for now and we can revisit.

non · 2020-10-11T04:04:46Z

OK yeah the SBT snippet didn't totally work so I released without Dotty. We can try to fix this before the real 1.15.0 release.

non · 2020-10-11T04:07:10Z

Anyway, just released 1.15.0-M1.

larsrh · 2020-10-12T19:51:37Z

I released a 0.27 artifact based on #684, which isn't yet merged, but since we're talking about a milestone release, I don't think that's problematic.

SethTisue · 2020-10-12T20:45:23Z

thanks Erik, thanks Lars! the 0.27 artifact is working great for me over in scala-parallel-collections 👍

non · 2020-10-12T22:24:00Z

Do you all feel like we should go ahead and release 1.15.0? I'm also up for doing an M2 if folks would rather be cautious.

SethTisue · 2020-10-13T00:07:06Z

(no opinion)

larsrh · 2020-10-13T07:19:19Z

There's a few open PRs tagged with 1.15.0. I suggest to go through with them and then follow up with RC1.

non · 2020-10-13T15:59:11Z

@larsrh Sounds good. I'm fine with merging both as-is or making changes. Would appreciate at least one more set of eyes.

larsrh · 2020-10-24T09:23:40Z

Are we ready for RC1? @SethTisue, @non?

larsrh · 2020-10-26T19:45:33Z

RC1 is out, final will follow next week if no issues are found.

SethTisue · 2020-10-26T19:55:06Z

okay if we keep this open until actual 1.15.0 is out?

larsrh · 2020-10-26T20:30:44Z

I took the liberty of filling in the gaps in the changelog.

larsrh · 2020-10-27T10:41:33Z

Release plan

Since Scalacheck doesn't use macros, many library authors that depend on Scalacheck used withDottyCompat. Now that we have a proper release, we need to get those out of the way, otherwise sbt complains about conflicting artifact qualifiers (_0.27 vs. _2.13).

SethTisue · 2020-10-31T16:11:59Z

Added to release notes:

This release was brought to you by 16 contributors, according to git shortlog -sn --no-merges 1.14.3..1.15.0. Thank you Scala Steward, Aaron S. Hawley, Erik Osheim, Lars Hupel, Dolan Murvihill, Alexey Kotlyarov, Zak, Seth Tisue, Taro L. Saito, Neville Li, P. Oscar Boykin, Guillaume Martres, Sean C. Sullivan, Fred Roth, Jonas Kölker, NthPortal.

SethTisue · 2020-10-31T16:17:22Z

@larsrh may I suggest that Typelevel tweet about this? possible tweet text:

ScalaCheck 1.15.0 is out! 👏🙏 to @aaron_s_hawley @D6 @larsr_h @rickynils and everyone else who contributed https://github.com/typelevel/scalacheck/releases/tag/1.15.0

SethTisue · 2020-10-31T16:24:18Z

if you omit yourself out of modesty I will be VERY ANGRY

larsrh · 2020-10-31T17:46:23Z

I did not, but I did include you 😉

SethTisue mentioned this issue Oct 8, 2020

add Dotty cross-build scala/scala-parallel-collections#113

Merged

larsrh mentioned this issue Oct 12, 2020

bump dotty #684

Merged

larsrh closed this as completed Oct 26, 2020

SethTisue reopened this Oct 26, 2020

larsrh added this to the 1.15.0 milestone Oct 27, 2020

larsrh closed this as completed Oct 31, 2020

Release 1.15.0 #668

Release 1.15.0 #668

Comments

ashawley commented Jun 4, 2020

ashawley commented Jun 4, 2020

Uh oh!

smarter commented Jul 31, 2020

Uh oh!

larsrh commented Aug 1, 2020

Uh oh!

SethTisue commented Sep 21, 2020

Uh oh!

ashawley commented Sep 22, 2020

Uh oh!

SethTisue commented Oct 8, 2020

Uh oh!

non commented Oct 10, 2020

Uh oh!

non commented Oct 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smarter commented Oct 11, 2020

Uh oh!

non commented Oct 11, 2020

Uh oh!

smarter commented Oct 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

non commented Oct 11, 2020

Uh oh!

non commented Oct 11, 2020

Uh oh!

non commented Oct 11, 2020

Uh oh!

larsrh commented Oct 12, 2020

Uh oh!

SethTisue commented Oct 12, 2020

Uh oh!

non commented Oct 12, 2020

Uh oh!

SethTisue commented Oct 13, 2020

Uh oh!

larsrh commented Oct 13, 2020

Uh oh!

non commented Oct 13, 2020

Uh oh!

larsrh commented Oct 24, 2020

Uh oh!

larsrh commented Oct 26, 2020

Uh oh!

SethTisue commented Oct 26, 2020

Uh oh!

larsrh commented Oct 26, 2020

Uh oh!

larsrh commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release plan

Uh oh!

SethTisue commented Oct 31, 2020

Uh oh!

SethTisue commented Oct 31, 2020

Uh oh!

SethTisue commented Oct 31, 2020

Uh oh!

larsrh commented Oct 31, 2020

Uh oh!

non commented Oct 11, 2020 •

edited

Loading

smarter commented Oct 11, 2020 •

edited

Loading

larsrh commented Oct 27, 2020 •

edited

Loading