Skip to content

Object.assign is missing in node 4/5/6 typings #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louy opened this issue Aug 13, 2016 · 6 comments
Open

Object.assign is missing in node 4/5/6 typings #22

louy opened this issue Aug 13, 2016 · 6 comments
Labels

Comments

@louy
Copy link
Member

louy commented Aug 13, 2016

Mentioned by @felixfbecker.

@louy louy added the bug label Aug 13, 2016
@felixfbecker felixfbecker changed the title Object.assign is missing in node 4/5/6 typings Object.assign is missing in node 5/6 typings Aug 13, 2016
@felixfbecker
Copy link

Object.assign was added in 5. Should we include it in 6 though? Node 6 is 100% ES6 compatible, so users can use target: ES6 and use es6.lib

@louy
Copy link
Member Author

louy commented Aug 13, 2016

Apparently it's supported in node 4.

louy@mb ~$ nvm use 4.0
Now using node v4.0.0 (npm v2.14.2)
louy@mb ~$ node -e 'console.log(Object.assign({}))'
{}

Also, these typings shouldn't rely on ts build target as the end goal is to support the noLib option. E.g. #14.

@felixfbecker felixfbecker changed the title Object.assign is missing in node 5/6 typings Object.assign is missing in node 4/5/6 typings Aug 13, 2016
@felixfbecker
Copy link

Sorry, my bad. But doesn't it make errors when lib and Node typings define the same method with the same signature?

@louy
Copy link
Member Author

louy commented Aug 13, 2016

It doesn't for functions. It does for properties, but there's a workaround (see #12).

@blakeembrey
Copy link
Member

I don't think we should be supporting noLib (it's a lot to replicate and TypeScript's domain), but definitely at the minimum supporting es{5,6}.core.d.ts.

@felixfbecker
Copy link

@louy what is the workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants