Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Cache: Fix project: includes #24

Open
bierbaum opened this issue Sep 28, 2022 · 0 comments
Open

Project Cache: Fix project: includes #24

bierbaum opened this issue Sep 28, 2022 · 0 comments

Comments

@bierbaum
Copy link
Contributor

Right now, project includes defined in projects are ignored by the project cache during generation. We should fix this.

   This doesn't allow projects that include sub-project targets, since I wasn't able to continue the work to get the project target resolution into try_from.

If you want all the recursive targets from a project that potentially includes other projects:

let targets = project.resolve_targets_for_project(catalog.optional_projects.underlying)

Originally posted by @conjohnerton in #22 (comment)
@bierbaum bierbaum mentioned this issue Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bierbaum