Cleanup

Author: twistedfall

.github/ISSUE_TEMPLATE/bug_report.md

@@ -13,7 +13,8 @@ the issue you're encountering is not solved thereby please state the following i
 1. Operating system
 2. The way you installed OpenCV: package, official binary distribution, manual compilation, etc.
 3. OpenCV version
-4. Attach the full output of the following command from your project directory:
+4. rustc version (`rustc --version`)
+5. Attach the full output of the following command from your project directory:
    ```shell script
    RUST_BACKTRACE=full cargo build -vv 
    ```

README.md

@@ -65,6 +65,8 @@ Installing OpenCV is easy through the following sources:
   ```shell script
   vcpkg install llvm opencv4[contrib,nonfree]
   ```
+  You most probably want to set environment variable `VCPKGRS_DYNAMIC` to "1" unless you're specifically
+  targeting a static build.
 
 ### macOS package
 
@@ -75,7 +77,7 @@ Get OpenCV from homebrew:
   brew install pkg-config opencv
   ```
   You will also need a working C++ compiler and libclang, you can use the ones from XCode or install `llvm`
-  from brew. You most probably need to also check the item 5 of the troubleshooting below.
+  from brew. You most probably need to also check the item 6 of the troubleshooting below.
 
 ### Manual build
 
@@ -120,7 +122,13 @@ You need to set up the following environment variables to point to the installed
    variable correctly or copy the dll next to the binary you're trying to run. Check
    [that](https://github.com/twistedfall/opencv-rust/issues/118#issuecomment-619608278) guide too.
 
-5. On macOS you're getting the `dyld: Library not loaded: @rpath/libclang.dylib` error during the build process.
+5. On Windows with VCPKG you're getting a lot of linking errors in multiple files like in
+   [this issue](https://github.com/twistedfall/opencv-rust/issues/161).
+   
+   Unless you're doing a very specific build, you want to have environment variable `VCPKGRS_DYNAMIC` set to
+   "1".
+
+6. On macOS you're getting the `dyld: Library not loaded: @rpath/libclang.dylib` error during the build process.
 
    OS can't find `libclang.dylib` dynamic library because it resides in a non-standard path, set up 
    the `DYLD_FALLBACK_LIBRARY_PATH` environment variable to point to the path where libclang.dylib can be

build.rs

@@ -745,7 +745,7 @@ impl Library {
 		let explicit_pkg_config = env::var_os("PKG_CONFIG_PATH").is_some() || env::var_os("OPENCV_PKGCONFIG_NAME").is_some();
 		let explicit_cmake = env::var_os("OpenCV_DIR").is_some()
 			|| env::var_os("OPENCV_CMAKE_NAME").is_some()
-			|| env::var_os("CMAKE_PREFIX_PATH").is_some();
+			|| env::var_os("CMAKE_PREFIX_PATH").is_some()
 			|| env::var_os("OPENCV_CMAKE_BIN").is_some();
 		let explicit_vcpkg = env::var_os("VCPKG_ROOT").is_some() || cfg!(target_os = "windows");
 

src/manual/core/vector.rs

@@ -216,7 +216,7 @@ impl<'a, T: VectorElement> Extend<<T as OpenCVType<'a>>::Arg> for Vector<T> wher
 		let s = s.into_iter();
 		let (lo, hi) = s.size_hint();
 		self.reserve(hi.unwrap_or(lo));
-		s.into_iter().for_each(|elem| {
+		s.for_each(|elem| {
 			self.push(elem);
 		});
 	}
@@ -300,7 +300,7 @@ impl<T: VectorElement> OpenCVTypeExternContainer for Vector<T> where Self: Vecto
 }
 
 #[inline(always)]
-pub(crate) fn vector_index_check(index: size_t, len: size_t) -> crate::Result<()> {
+fn vector_index_check(index: size_t, len: size_t) -> crate::Result<()> {
 	if index >= len {
 		Err(crate::Error::new(crate::core::StsOutOfRange, format!("Index: {} out of bounds: 0..{}", index, len)))
 	} else {