Voice Test Fixes (#436)

* Due to error wrapping that happens in lib/util/Request.js#handleError, err no longer has response field

* TransferTask fixes

* Enabling the rest of the tests

* axios bump

Author: rsi2m

package.json

@@ -57,7 +57,7 @@
   },
   "dependencies": {
     "@babel/runtime": "^7.16.3",
-    "axios": "^1.7.9",
+    "axios": "^1.8.2 ",
     "events": "3.3.0",
     "graphql": "^14",
     "graphql-ws": "^5.16.2",

test/voice/outbound/spec/Task.js

@@ -10,6 +10,7 @@ const credentials = require('../../../env');
 const chai = require('chai');
 chai.use(require('sinon-chai'));
 const assert = chai.assert;
+const expect = chai.expect;
 
 describe('Outbound Voice Task', () => {
     const aliceToken = getAccessToken(credentials.accountSid, credentials.multiTaskWorkspaceSid, credentials.multiTaskAliceSid);
@@ -176,15 +177,15 @@ describe('Outbound Voice Task', () => {
                         await aliceReservation.task.hold(credentials.multiTaskBobSid, true);
                         reject('Failed to throw 400 on request to hold worker B');
                     } catch (err) {
-                        assert.strictEqual(err.response.status, 400, 'Task on-hold request failure error code');
+                        expect(err.toString()).contain('status code 400', 'Task on-hold request failure error code');;
                     }
 
                     // Worker B tries to put worker A on hold
                     try {
                         await bobReservation.task.hold(credentials.multiTaskAliceSid, true);
                         reject('Failed to throw 400 on request to hold worker A');
                     } catch (err) {
-                        assert.strictEqual(err.response.status, 400, 'Task on-hold request failure error code');
+                        expect(err.toString()).contain('status code 400', 'Task on-hold request failure error code');
                     }
                     resolve('Outbound test fail if worker A put worker B (and vice versa) on hold if they are not in same conference');
                 } catch (err) {
@@ -219,15 +220,15 @@ describe('Outbound Voice Task', () => {
                             await aliceReservation.task.hold(credentials.multiTaskBobSid, true);
                             reject('Failed to throw 400 on request to hold worker B');
                         } catch (err) {
-                            assert.strictEqual(err.response.status, 400, 'Task on-hold request failure error code');
+                            expect(err.toString()).contain('status code 400', 'Task on-hold request failure error code');
                         }
 
                         // Worker B tries to put worker A on hold
                         try {
                             await bobReservation.task.hold(credentials.multiTaskAliceSid, true);
                             reject('Failed to throw 400 on request to hold worker A');
                         } catch (err) {
-                            assert.strictEqual(err.response.status, 400, 'Task on-hold request failure error code');
+                            expect(err.toString()).contain('status code 400', 'Task on-hold request failure error code');
                             resolve('Outbound test to fail when worker A puts worker B (and vice-versa) on hold if reservation of worker B is pending');
                         }
                     } catch (err) {
@@ -246,38 +247,37 @@ describe('Outbound Voice Task', () => {
         it('should throw a validation error when using an incorrect workflow sid', () => {
             return new Promise(async(resolve, reject) => {
                 // eslint-disable-next-line
-                const expected = `Value \'${credentials.multiTaskWorkflowSid}z\' provided for` +
-                                 ' WorkflowSid has an invalid format';
+                const expectedDownstreamStatusText = `Value \'${credentials.multiTaskWorkflowSid}z\' provided for` +
+                    ' WorkflowSid has an invalid format';
+                const expectedErrorMessage = `Request failed with status code 400. ${expectedDownstreamStatusText}`
                 try {
 
                     await alice.createTask(credentials.customerNumber, credentials.flexCCNumber,
-                                           credentials.multiTaskWorkflowSid, credentials.multiTaskQueueSid);
+                        credentials.multiTaskWorkflowSid, credentials.multiTaskQueueSid);
 
                     await alice.createTask(credentials.customerNumber, credentials.flexCCNumber,
-                                           credentials.multiTaskWorkflowSid + 'z', credentials.multiTaskQueueSid);
+                        credentials.multiTaskWorkflowSid + 'z', credentials.multiTaskQueueSid);
                     reject('Invalid WorkflowSid should be rejected');
                 } catch (err) {
-                    assert.strictEqual(err.response.status, 400, 'expecting a bad request');
-                    assert.strictEqual(err.response.statusText, expected,
-                                       'Got a different validation failure than expected');
+                    assert.strictEqual(err.message, expectedErrorMessage,
+                        'Got a different validation failure than expected');
                     resolve('Test for validation error when using an incorrect workflowSid finished');
                 }
             });
         }).timeout(5000);
 
         it('should throw a validation error when using an incorrect queue sid', () => {
             return new Promise(async(resolve, reject) => {
+                let expectedErrorMessage = 'Request failed with status code 400. HTTP 400 Bad Request';
                 try {
                     await alice.createTask(credentials.customerNumber, credentials.flexCCNumber,
-                                           credentials.multiTaskWorkflowSid, credentials.multiTaskQueueSid + 'z');
+                        credentials.multiTaskWorkflowSid, credentials.multiTaskQueueSid + 'z');
                     reject('Invalid QueueSid should be rejected');
                 } catch (err) {
-                    assert.strictEqual(err.response.status, 400, 'expecting a bad request');
-                    // taskrouter doesn't send a validation message here
+                    assert.strictEqual(err.message, expectedErrorMessage, 'expecting a bad request');
                     resolve('Test for validation error when using an incorrect QueueSid finished');
                 }
             });
         }).timeout(5000);
     });
-});
-
+});

test/voice/outbound/spec/TaskTransferToWorker.js

@@ -15,6 +15,7 @@ const credentials = require('../../../env');
 const chai = require('chai');
 chai.use(require('sinon-chai'));
 const assert = chai.assert;
+const expect = chai.expect;
 
 describe('Task Transfer to Worker for Outbound Voice Task', () => {
     const aliceToken = getAccessToken(credentials.accountSid, credentials.multiTaskWorkspaceSid,
@@ -360,7 +361,7 @@ describe('Task Transfer to Worker for Outbound Voice Task', () => {
                         try {
                             await aliceReservation.task.transfer(credentials.multiTaskBobSid, { mode: TRANSFER_MODE.cold });
                         } catch (err) {
-                            assert.strictEqual(err.response.status, 400, 'Task transfer failure error code');
+                            expect(err.toString()).contain('status code 400', 'Task transfer failure error code');
                             resolve('Test to fail initiating transfer when transferee is unavailable is finished.');
                         }
                     } catch (err) {
@@ -922,7 +923,7 @@ describe('Task Transfer to Worker for Outbound Voice Task', () => {
                             }
                         } catch (err) {
                             reject(
-                              `Failed to validate Reservation and Transfer properties sid=${bobReservation.sid}. Error: ${err}`);
+                                `Failed to validate Reservation and Transfer properties sid=${bobReservation.sid}. Error: ${err}`);
                         }
                     });