Skip to content

Regression from v1 to v2 phone number lookups-- URI no longer encoded #659

Open
@bf4

Description

@bf4

Issue Summary

Same issue as #406

I see from v1 https://github.com/twilio/twilio-ruby/blob/6.0.2/lib/twilio-ruby/rest/lookups/v1/phone_number.rb#L53 to v2 the escaping was removed.

-                        @uri = "/PhoneNumbers/#{CGI.escape(@solution[:phone_number]).gsub("+", "%20")}"
+                        @uri = "/PhoneNumbers/#{@solution[:phone_number]}"

Proposal

use URI::DEFAULT_PARSER.escape just like Rails does

                        @uri = "/PhoneNumbers/#{URI::DEFAULT_PARSER.escape(@solution[:phone_number])}"

Steps to Reproduce

  1. look up a phone number with a space in it

see #406

Code Snippet

see #406

Exception/Log

see #406

Technical details:

  • twilio-ruby version: 6.0.1
  • ruby version: 3.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions