chore: handle integer maps in openapi (#694)

### Context
For objects that are maps having key as string and value as integer, the
open-api definition looks something like this:
```
schema_name:
    type: object
    additionalProperties:
      type: integer
```
This was not present in public specs till now. But now it is present in
one of the spec files
[here](https://code.hq.twilio.com/twilio/open-api/blob/f52384fce4c47d3c2d12ef70b39c6b860dd2d701/spec/insights/v2/schemas.yaml#L208).

### Error and its root cause
When something like this is processed by our generator, it throws the
following error:
```
java.util.regex.PatternSyntaxException: Illegal repetition
{ [key: string]: number; } occurs in NodeCodegenModelDataTypeResolver.java:66
```
This arises because when the Twilio Node generator processes
additionalProperties definitions as mentioned above, it generates
TypeScript-like type definitions such as:
 ` { [key: string]: number; }`

In NodeCodegenModelDataTypeResolver.java:66, this generated type string
is incorrectly used as a regex pattern in the replaceFirst() method:

 ```
consumer.accept(datatypeWithEnum, dataType.replaceFirst(baseType,
datatypeWithEnum));
```

  The problem is that { [key: string]: number; } contains curly braces {} which have special meaning in regex as quantifiers (e.g., {n} means "exactly n times"). However, the braces in `{ [key: string]: number; }` are not properly formatted as regex quantifiers, causing the "Illegal repetition" error.

### Solution

  The fix is to escape the baseType parameter before using it as a regex pattern with the help of Pattern.quote() method which treats the string as a literal pattern, escaping any regex special characters.

### Difference
The change is relevant for fluent api languages like node, python and ruby. However, as mentioned above, since we didn't have any string-to-int map till now in our open-api specs, the change does not create any difference in the existing helpers.

### Checklist
- [x] I acknowledge that all my contributions will be made under the project's license
- [ ] Run `make test-docker`
- [ ] Verify affected language:
    - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff
    - [ ] Run `make test` in `twilio-go`
    - [ ] Create a pull request in `twilio-go`
    - [ ] Provide a link below to the pull request
- [ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
- [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them
- [ ] I have titled the PR appropriately
- [ ] I have updated my branch with the main branch
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added the necessary documentation about the functionality in the appropriate .md file
- [ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Author: tiwarishubham635

examples/csharp/src/Twilio/Rest/Versionless/DeployedDevices/FleetResource.cs

@@ -202,6 +202,10 @@ public static string ToJson(object model)
         [JsonProperty("name")]
         public string Name { get; private set; }
 
+        ///<summary> The test_int_map </summary> 
+        [JsonProperty("test_int_map")]
+        public Dictionary<string, int> TestIntMap { get; private set; }
+
         ///<summary> A string that uniquely identifies this Fleet. </summary> 
         [JsonProperty("sid")]
         public string Sid { get; private set; }

examples/java/src/main/java/com/twilio/rest/versionless/deployedDevices/Fleet.java

@@ -127,6 +127,7 @@ public static Fleet fromJson(final InputStream json, final ObjectMapper objectMa
     }
 
     private final String name;
+    private final Map<String, Integer> testIntMap;
     private final String sid;
     private final String friendlyName;
 
@@ -135,20 +136,27 @@ private Fleet(
         @JsonProperty("name")
         final String name,
 
+        @JsonProperty("test_int_map")
+        final Map<String, Integer> testIntMap,
+
         @JsonProperty("sid")
         final String sid,
 
         @JsonProperty("friendly_name")
         final String friendlyName
     ) {
         this.name = name;
+        this.testIntMap = testIntMap;
         this.sid = sid;
         this.friendlyName = friendlyName;
     }
 
         public final String getName() {
             return this.name;
         }
+        public final Map<String, Integer> getTestIntMap() {
+            return this.testIntMap;
+        }
         public final String getSid() {
             return this.sid;
         }
@@ -168,12 +176,12 @@ public boolean equals(final Object o) {
 
         Fleet other = (Fleet) o;
 
-        return Objects.equals(name, other.name) &&  Objects.equals(sid, other.sid) &&  Objects.equals(friendlyName, other.friendlyName)  ;
+        return Objects.equals(name, other.name) &&  Objects.equals(testIntMap, other.testIntMap) &&  Objects.equals(sid, other.sid) &&  Objects.equals(friendlyName, other.friendlyName)  ;
     }
 
     @Override
     public int hashCode() {
-        return Objects.hash(name, sid, friendlyName);
+        return Objects.hash(name, testIntMap, sid, friendlyName);
     }
 
 

examples/node/src/rest/versionless/deployed_devices/fleet.ts

@@ -109,6 +109,7 @@ interface FleetPayload extends FleetResource {}
 
 interface FleetResource {
   name: string;
+  test_int_map: { [key: string]: number };
   sid: string;
   friendly_name: string;
 }
@@ -123,13 +124,15 @@ export class FleetInstance {
     sid?: string,
   ) {
     this.name = payload.name;
+    this.testIntMap = payload.test_int_map;
     this.sid = payload.sid;
     this.friendlyName = payload.friendly_name;
 
     this._solution = { sid: sid || this.sid };
   }
 
   name: string;
+  testIntMap: { [key: string]: number };
   /**
    * A string that uniquely identifies this Fleet.
    */
@@ -166,6 +169,7 @@ export class FleetInstance {
   toJSON() {
     return {
       name: this.name,
+      testIntMap: this.testIntMap,
       sid: this.sid,
       friendlyName: this.friendlyName,
     };

examples/php/src/Twilio/Rest/Versionless/DeployedDevices/FleetInstance.php

@@ -32,6 +32,7 @@
 
 /**
  * @property string $name
+ * @property array<string,int> $testIntMap
  * @property string|null $sid
  * @property string|null $friendlyName
  */
@@ -51,6 +52,7 @@ public function __construct(Version $version, array $payload, ?string $sid = nul
         // Marshaled Properties
         $this->properties = [
             'name' => Values::array_get($payload, 'name'),
+            'testIntMap' => Values::array_get($payload, 'test_int_map'),
             'sid' => Values::array_get($payload, 'sid'),
             'friendlyName' => Values::array_get($payload, 'friendly_name'),
         ];

examples/python/twilio/rest/versionless/deployed_devices/fleet.py

@@ -25,6 +25,7 @@ class FleetInstance(InstanceResource):
 
     """
     :ivar name:
+    :ivar test_int_map:
     :ivar sid: A string that uniquely identifies this Fleet.
     :ivar friendly_name: A human readable description for this Fleet.
     """
@@ -35,6 +36,7 @@ def __init__(
         super().__init__(version)
 
         self.name: Optional[str] = payload.get("name")
+        self.test_int_map: Optional[dict[str, int]] = payload.get("test_int_map")
         self.sid: Optional[str] = payload.get("sid")
         self.friendly_name: Optional[str] = payload.get("friendly_name")
 

examples/ruby/lib/twilio-ruby/rest/versionless/deployed_devices/fleet.rb

@@ -142,6 +142,7 @@ def initialize(version, payload, sid: nil)
             # Marshaled Properties
             @properties = {
               'name' => payload['name'],
+              'test_int_map' => payload['test_int_map'],
               'sid' => payload['sid'],
               'friendly_name' => payload['friendly_name'],
             }
@@ -168,6 +169,12 @@ def name
             @properties['name']
           end
 
+          ##
+          # @return [Hash<String, Integer>]
+          def test_int_map
+            @properties['test_int_map']
+          end
+
           ##
           # @return [String] A string that uniquely identifies this Fleet.
           def sid

examples/spec/twilio_versionless.yaml

@@ -5,6 +5,10 @@ components:
       properties:
         name:
           type: string
+        test_int_map:
+          type: object
+          additionalProperties:
+            type: integer
     versionless.fleet.instance:
       type: object
       properties:

src/main/java/com/twilio/oai/api/FluentApiResourceBuilder.java

@@ -12,6 +12,7 @@
 import java.util.Objects;
 import java.util.TreeMap;
 import java.util.function.BiConsumer;
+import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
 import org.openapitools.codegen.CodegenModel;
@@ -198,7 +199,7 @@ protected void updateDataType(final String baseType,
 
         if (baseType != null) {
             final String datatypeWithEnum = getDataTypeName(baseType);
-            consumer.accept(datatypeWithEnum, dataType.replaceFirst(baseType, datatypeWithEnum));
+            consumer.accept(datatypeWithEnum, dataType.replaceFirst(Pattern.quote(baseType), datatypeWithEnum));
         }
     }
 

src/main/java/com/twilio/oai/resolver/node/NodeCodegenModelDataTypeResolver.java

@@ -9,6 +9,7 @@
 
 import java.util.Map;
 import java.util.function.BiConsumer;
+import java.util.regex.Pattern;
 
 import com.twilio.oai.resolver.common.CodegenModelResolver;
 import org.openapitools.codegen.CodegenModel;
@@ -63,7 +64,7 @@ private void updateDataType(final String baseType,
 
         if (baseType != null && dataType != null) {
             final String datatypeWithEnum = removeEnumName(baseType, apiResourceBuilder);
-            consumer.accept(datatypeWithEnum, dataType.replaceFirst(baseType, datatypeWithEnum));
+            consumer.accept(datatypeWithEnum, dataType.replaceFirst(Pattern.quote(baseType), datatypeWithEnum));
         }
     }
 

src/main/java/com/twilio/oai/resolver/python/PythonCodegenModelDataTypeResolver.java

@@ -12,6 +12,7 @@
 
 import java.util.Map;
 import java.util.function.BiConsumer;
+import java.util.regex.Pattern;
 
 // Overriding default behavior and handling the enum
 public class PythonCodegenModelDataTypeResolver extends CodegenModelDataTypeResolver {
@@ -103,7 +104,7 @@ private void updateDataType(final String baseType,
 
         if (baseType != null && dataType != null) {
             final String datatypeWithEnum = removeEnumName(baseType, apiResourceBuilder);
-            consumer.accept(datatypeWithEnum, dataType.replaceFirst(baseType, datatypeWithEnum));
+            consumer.accept(datatypeWithEnum, dataType.replaceFirst(Pattern.quote(baseType), datatypeWithEnum));
         }
     }