Add nullable & implicit usings

Author: Swimburger

README.md

@@ -552,7 +552,7 @@ bool IsValidTwilioRequest(HttpContext httpContext)
         ?.Value ?? throw new Exception("TwilioRequestValidationOptions missing.");
 
     string? urlOverride = null;
-    if (options.BaseUrlOverride != null)
+    if (options.BaseUrlOverride is not null)
     {
         var request = httpContext.Request;
         urlOverride = $"{options.BaseUrlOverride.TrimEnd('/')}{request.Path}{request.QueryString}";

src/Twilio.AspNet.Common/SmsRequest.cs

@@ -9,32 +9,33 @@ public class SmsRequest : TwilioRequest
     /// <summary>
     /// A 34 character unique identifier for the message. May be used to later retrieve this message from the REST API.
     /// </summary>
-    public string MessageSid { get; set; }
-        
+    public string MessageSid { get; set; } = null!;
+
     /// <summary>
     /// Same value as MessageSid. Deprecated and included for backward compatibility.
     /// </summary>
-    public string SmsSid { get; set; }
+    [Obsolete("Use MessageSid instead")]
+    public string SmsSid { get; set; }= null!;
 
     /// <summary>
     /// The text body of the SMS message. Up to 160 characters long
     /// </summary>
-    public string Body { get; set; }
+    public string Body { get; set; }= null!;
 
     /// <summary>
     /// The status of the message
     /// </summary>
-    public string MessageStatus { get; set; }
+    public string MessageStatus { get; set; }= null!;
 
     /// <summary>
     /// The message OptOut type 
     /// </summary>
-    public string OptOutType { get; set; }
+    public string? OptOutType { get; set; }
 
     /// <summary>
     /// A unique identifier of the messaging service
     /// </summary>
-    public string MessagingServiceSid { get; set; }
+    public string? MessagingServiceSid { get; set; }
 
     /// <summary>
     /// The number of media items associated with your message

src/Twilio.AspNet.Common/SmsStatusCallbackRequest.cs

@@ -9,32 +9,32 @@ public class SmsStatusCallbackRequest: SmsRequest
     /// will be present. Find the possible values here:
     /// https://www.twilio.com/docs/sms/api/message-resource#delivery-related-errors
     /// </summary>
-    public string ErrorCode { get; set; }
+    public string? ErrorCode { get; set; }
 
     /// <summary>
     /// The Installed Channel SID (found on the Channel detail page) that was 
     /// used to send this message. Only present if the message was sent using a 
     /// Channel.
     /// </summary>
-    public string ChannelInstallSid { get; set; }
+    public string? ChannelInstallSid { get; set; }
 
     /// <summary>
     /// The Error message returned by the underlying Channel if Message delivery 
     /// failed. Only present if the message was sent using a Channel and message 
     /// delivery failed.
     /// </summary>
-    public string ChannelStatusMessage { get; set; }
+    public string? ChannelStatusMessage { get; set; }
 
     /// <summary>
     /// Channel specific prefix that allows you to identify which channel this 
     /// message was sent over.
     /// </summary>
-    public string ChannelPrefix { get; set; }
+    public string? ChannelPrefix { get; set; }
 
     /// <summary>
     /// Contains post-delivery events. If the Channel supports Read receipts, this 
     /// parameter will be included with a value of READ after the user has read 
     /// the message. Currently supported only for WhatsApp.
     /// </summary>
-    public string EventType { get; set; }
+    public string? EventType { get; set; }
 }

src/Twilio.AspNet.Common/StatusCallbackRequest.cs

@@ -11,7 +11,7 @@ public class StatusCallbackRequest : VoiceRequest
     /// </summary>
     public float CallDuration { get; set; }
 
-    public string Called { get; set; }
-    public string Caller { get; set; }
+    public string? Called { get; set; } 
+    public string? Caller { get; set; }
     public float Duration { get; set; }
 }

src/Twilio.AspNet.Common/Twilio.AspNet.Common.csproj

@@ -2,6 +2,8 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <LangVersion>13</LangVersion>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
     <OutputType>Library</OutputType>
     <Version>0.0.0-alpha</Version>
     <PackageId>Twilio.AspNet.Common</PackageId>
@@ -15,6 +17,7 @@
     <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/twilio/twilio-aspnet</PackageProjectUrl>
     <RepositoryUrl>https://github.com/twilio-labs/twilio-aspnet.git</RepositoryUrl>
+    <RepositoryType>git</RepositoryType>
     <PackageIconUrl>https://s3.amazonaws.com/com.twilio.prod.twilio-docs/images/twilio-icon-64x64.png</PackageIconUrl>
     <PackageIcon>icon.png</PackageIcon>
     <PackageReadmeFile>README.md</PackageReadmeFile>

src/Twilio.AspNet.Common/TwilioRequest.cs

@@ -8,61 +8,61 @@ public abstract class TwilioRequest
     /// <summary>
     /// Your Twilio account id. It is 34 characters long, and always starts with the letters AC
     /// </summary>
-    public string AccountSid { get; set; }
+    public string AccountSid { get; set; } = null!;
 
     /// <summary>
     /// The phone number or client identifier of the party that initiated the call
     /// </summary>
     /// <remarks>
     /// Phone numbers are formatted with a '+' and country code, e.g. +16175551212 (E.164 format). Client identifiers begin with the client: URI scheme; for example, for a call from a client named 'tommy', the From parameter will be client:tommy.
     /// </remarks>
-    public string From { get; set; }
+    public string From { get; set; } = null!;
 
     /// <summary>
     /// The phone number or client identifier of the called party
     /// </summary>
     /// <remarks>
     /// Phone numbers are formatted with a '+' and country code, e.g. +16175551212 (E.164 format). Client identifiers begin with the client: URI scheme; for example, for a call to a client named 'jenny', the To parameter will be client:jenny.
     /// </remarks>
-    public string To { get; set; }
+    public string To { get; set; } = null!;
 
     /// <summary>
     /// The city of the caller
     /// </summary>
-    public string FromCity { get; set; }
+    public string? FromCity { get; set; }
 
     /// <summary>
     /// The state or province of the caller
     /// </summary>
-    public string FromState { get; set; }
+    public string? FromState { get; set; }
 
     /// <summary>
     /// The postal code of the caller
     /// </summary>
-    public string FromZip { get; set; }
+    public string? FromZip { get; set; }
 
     /// <summary>
     /// The country of the caller
     /// </summary>
-    public string FromCountry { get; set; }
+    public string? FromCountry { get; set; }
 
     /// <summary>
     /// The city of the called party
     /// </summary>
-    public string ToCity { get; set; }
+    public string? ToCity { get; set; }
 
     /// <summary>
     /// The state or province of the called party
     /// </summary>
-    public string ToState { get; set; }
+    public string? ToState { get; set; }
 
     /// <summary>
     /// The postal code of the called party
     /// </summary>
-    public string ToZip { get; set; }
+    public string? ToZip { get; set; }
 
     /// <summary>
     /// The country of the called party
     /// </summary>
-    public string ToCountry { get; set; }
+    public string? ToCountry { get; set; }
 }

src/Twilio.AspNet.Common/VoiceRequest.cs

@@ -9,53 +9,53 @@ public class VoiceRequest : TwilioRequest
     /// <summary>
     /// A unique identifier for this call, generated by Twilio
     /// </summary>
-    public string CallSid { get; set; }
+    public string CallSid { get; set; } = null!;
 
     /// <summary>
     /// A descriptive status for the call. The value is one of queued, ringing, in-progress, completed, busy, failed or no-answer
     /// </summary>
-    public string CallStatus { get; set; }
+    public string CallStatus { get; set; } = null!;
 
     /// <summary>
     /// The version of the Twilio API used to handle this call. For incoming calls, this is determined by the API version set on the called number. For outgoing calls, this is the API version used by the outgoing call's REST API request
     /// </summary>
-    public string ApiVersion { get; set; }
+    public string ApiVersion { get; set; } = null!;
 
     /// <summary>
     /// Indicates the direction of the call. In most cases this will be inbound, but if you are using Dial it will be outbound-dial
     /// </summary>
-    public string Direction { get; set; }
+    public string Direction { get; set; } = null!;
 
     /// <summary>
     /// This parameter is set only when Twilio receives a forwarded call, but its value depends on the caller's carrier including information when forwarding. Not all carriers support passing this information
     /// </summary>
-    public string ForwardedFrom { get; set; }
+    public string? ForwardedFrom { get; set; }
 
     /// <summary>
     /// This parameter is set when the IncomingPhoneNumber that received the call has had its VoiceCallerIdLookup value set to true.
     /// </summary>
-    public string CallerName { get; set; }
+    public string? CallerName { get; set; }
 
     /// <summary>
     /// A unique identifier for the call that created this leg. This parameter is not passed if this is the first leg of a call.
     /// </summary>
-    public string ParentCallSid { get; set; }
+    public string? ParentCallSid { get; set; }
 
     /// <summary>A token string needed to invoke a forwarded call.</summary>
-    public string CallToken { get; set; }
+    public string? CallToken { get; set; }
 
     #region Gather & Record Parameters
 
     /// <summary>
     /// When used with the Gather verb, the digits the caller pressed, excluding the finishOnKey digit if used.  
     /// When used with the Record verb, the key (if any) pressed to end the recording or 'hangup' if the caller hung up
     /// </summary>
-    public string Digits { get; set; }
+    public string? Digits { get; set; }
 
     /// <summary>
     /// When used with the Gather verb, the transcribed result of the speech
     /// </summary>
-    public string SpeechResult { get; set; }
+    public string? SpeechResult { get; set; }
 
     /// <summary>
     /// When used with the Gather verb, a confidence score between 0.0 and 1.0 respectively.
@@ -66,17 +66,17 @@ public class VoiceRequest : TwilioRequest
     /// <summary>
     /// The URL of the recorded audio.  When the result of a transcription, the URL for the transcription's source recording resource.
     /// </summary>
-    public string RecordingUrl { get; set; }
+    public string? RecordingUrl { get; set; }
 
     /// <summary>
     /// The status of the recording. Possible values are: completed, failed.
     /// </summary>
-    public string RecordingStatus { get; set; }
+    public string? RecordingStatus { get; set; }
 
     /// <summary>
     /// The duration of the recorded audio (in seconds)
     /// </summary>
-    public string RecordingDuration { get; set; }
+    public string? RecordingDuration { get; set; }
 
     /// <summary>
     /// The number of channels in the final recording file as an integer.
@@ -86,12 +86,12 @@ public class VoiceRequest : TwilioRequest
     /// <summary>
     /// The source of the recorded audio.
     /// </summary>
-    public string RecordingSource { get; set; }
+    public string? RecordingSource { get; set; }
 
     /// <summary>
     /// The key used to submit the digits
     /// </summary>
-    public string FinishedOnKey { get; set; }
+    public string? FinishedOnKey { get; set; }
 
     #endregion
 
@@ -100,27 +100,27 @@ public class VoiceRequest : TwilioRequest
     /// <summary>
     /// The unique 34 character ID of the transcription
     /// </summary>
-    public string TranscriptionSid { get; set; }
+    public string? TranscriptionSid { get; set; }
 
     /// <summary>
     /// Contains the text of the transcription
     /// </summary>
-    public string TranscriptionText { get; set; }
+    public string? TranscriptionText { get; set; }
 
     /// <summary>
     /// The status of the transcription attempt: either 'completed' or 'failed'
     /// </summary>
-    public string TranscriptionStatus { get; set; }
+    public string? TranscriptionStatus { get; set; }
 
     /// <summary>
     /// The URL for the transcription's REST API resource
     /// </summary>
-    public string TranscriptionUrl { get; set; }
+    public string? TranscriptionUrl { get; set; }
 
     /// <summary>
     /// The unique 34 character ID of the recording from which the transcription was generated
     /// </summary>
-    public string RecordingSid { get; set; }
+    public string? RecordingSid { get; set; }
 
     #endregion
 
@@ -129,17 +129,17 @@ public class VoiceRequest : TwilioRequest
     /// <summary>
     /// The outcome of the Dial attempt. See the DialCallStatus section below for details
     /// </summary>
-    public string DialCallStatus { get; set; }
+    public string? DialCallStatus { get; set; }
 
     /// <summary>
     /// The call sid of the new call leg. This parameter is not sent after dialing a conference
     /// </summary>
-    public string DialCallSid { get; set; }
+    public string? DialCallSid { get; set; }
 
     /// <summary>
     /// The duration in seconds of the dialed call. This parameter is not sent after dialing a conference
     /// </summary>
-    public string DialCallDuration { get; set; }
+    public string? DialCallDuration { get; set; }
 
     #endregion
 
@@ -148,22 +148,22 @@ public class VoiceRequest : TwilioRequest
     /// <summary>
     /// The Twilio SIP Domain to which the INVITE was sent
     /// </summary>
-    public string SipDomain { get; set; }
+    public string? SipDomain { get; set; }
 
     /// <summary>
     /// The username given when authenticating the request, if Credential List is the authentication method.
     /// </summary>
-    public string SipUsername { get; set; }
+    public string? SipUsername { get; set; }
 
     /// <summary>
     /// The Call-Id of the incoming INVITE
     /// </summary>
-    public string SipCallId { get; set; }
+    public string? SipCallId { get; set; }
 
     /// <summary>
     /// The IP Address the incoming INVITE came from.
     /// </summary>
-    public string SipSourceIp { get; set; }
+    public string? SipSourceIp { get; set; }
 
     #endregion
 }