Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean commits #69

Closed
stappersg opened this issue Jun 11, 2023 · 4 comments
Closed

Clean commits #69

stappersg opened this issue Jun 11, 2023 · 4 comments

Comments

@stappersg
Copy link
Contributor

This issue is for having a place to elaborate upcoming merge requests for me.
Some of those _MR_s will have @marlonbaeten as author.

Goal of this issue is having clean commits. Assumed is that we know that the reason for clean commits is that it is a way to tell our future selfs and co-workers what did change and for which reason.

@stappersg
Copy link
Contributor Author

There are now this merge requests

It is #78 that shows how #62 was fixed, and #79 does that for #64

@stappersg
Copy link
Contributor Author

stappersg commented Jun 14, 2023

The above references are the advised sequence to merge. Now in text:

After that, we find out how much rebase work for #80 and #85 is needed.

@marlonbaeten
Copy link
Member

Hi Geert, I really appreciate the effort you put in to this, with the goal to make Mailcrab even better.
Unfortunately I'm not convinced that reverting commits, and then re-applying them makes the history easier to understand. You are right that it might be better to split work into logical and small commits, I'll try my best next time.
Anyway we have this issue together with your PR's as a public record for the reasoning for all these changes.

I'll close the PR's for now - could you maybe base the version commit on main? I be glab to merge that.

@stappersg
Copy link
Contributor Author

be better to split work into logical and small commits

Example given #91

@stappersg stappersg mentioned this issue Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants