Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Testing with Cypress Lesson #642

Open
wvmitchell opened this issue Mar 7, 2023 · 1 comment
Open

Update Testing with Cypress Lesson #642

wvmitchell opened this issue Mar 7, 2023 · 1 comment
Assignees
Labels
Lesson An issue affecting a lesson M3 M3 task

Comments

@wvmitchell
Copy link
Collaborator

wvmitchell commented Mar 7, 2023

Lesson to be updated: Testing with Cypress

Summary of changes needed:

  • Classes are referred to in several places throughout this lesson, this should change to reflect the fact that students will be most familiar with functional React at this point

  • Additionally, this lesson needs an overall review, to ensure that it meets our standards, outlined by the lesson creation guidelines below

  • We need to add screenshots and/or links to the docs to help students understand how to see whether their network requests are being properly intercepted.

Lesson creation guidelines (also on FE Hub)

Additional changes

  • Remove class based components from this repo that is used in the lesson
  • Update repo to React 18
  • Update repo to Router v6
  • Refactor as needed based on these updates
@wvmitchell wvmitchell added M3 M3 task Lesson An issue affecting a lesson labels Mar 7, 2023
@hfaerber hfaerber self-assigned this May 18, 2023
@hfaerber
Copy link
Contributor

hfaerber commented Jun 8, 2023

This ticket has 2 PRs ready for review:

  • Updates to the repo used in the lesson are ready for review on this PR
  • Updates to the lesson itself are ready for review on this PR

@hfaerber hfaerber mentioned this issue Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lesson An issue affecting a lesson M3 M3 task
Projects
None yet
Development

No branches or pull requests

3 participants