Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update What's Cookin Part 1 Project #616

Open
wvmitchell opened this issue Feb 17, 2023 · 4 comments · Fixed by #646
Open

Update What's Cookin Part 1 Project #616

wvmitchell opened this issue Feb 17, 2023 · 4 comments · Fixed by #646
Assignees
Labels
M2 M2 task Project An issue affecting a project

Comments

@wvmitchell
Copy link
Collaborator

wvmitchell commented Feb 17, 2023

Project to be updated: What's Cooking Part 1

Summary of changes needed:

  • The current project outlines the use of classes to build the project
  • The started repo similarly pushes students to build out classes
  • The push to use classes needs to be removed to instead push students to functions
  • All group projects should make clear that a failure to participate can result in an individual failing the project, even if the project is otherwise passing
  • Update rubrics to use the Yes, Not Yet, Wow scale that was piloted on M1 projects. Use What's Cookin Part 1 FP updates as a guide for consistency.
  • Use of closures is a WOW option for M2 projects.
  • Function purity is not a wow but should be listed as a JS competency example for M2

Verbiage examples used across M2 project updates:

In rubric competency examples:

  • Demonstrates efforts towards making functions pure when possible. Note: Purity is not possible for every function in a FE application. Strive for it only when it makes sense.
  • WOW option: Effectively implements one or more closure throughout project. Note: See Closures lesson on M2 lesson page as a resource.

Added to bottom of rubric:

"### Collaboration and Professionalism

  • See "Minimum Collaboration and Professionalism Expectations" above.
  • While this is not a scored rubric section, every team member is expected to fully participate, contribute, communicate and collaborate with the team throughout the entirety of this project. Failure to do so can result in an individual failing the project, even if the group/project is otherwise passing."
@wvmitchell wvmitchell added M2 M2 task Project An issue affecting a project labels Feb 17, 2023
@hfaerber hfaerber self-assigned this Feb 24, 2023
@hfaerber
Copy link
Contributor

hfaerber commented Feb 24, 2023

Still needs done:
- updated starter kit repo
- display on projects page (because created a new file for this under m2 project folder)

@hfaerber
Copy link
Contributor

hfaerber commented Mar 3, 2023

Link to open PR with spec updates

Questions I have:
- How should we structure the files? What should the files names be? domUpdates.js and index.js?. Cass and I decided on leaving the scripts.js file and adding a domUpdates.js file
- How to outline what they need to test? All non-dom-updating functions?
- Line 8 learning goal mentions 'modular'. If we just do 2 files, is it really modular? Removed word modular
- Are we looking for purity/closures/anything else? Should that be in the learning goals or the rubric anywhere?
- 2 of the methods from the users iteration are the same as the previous iteration. They shouldn't build new functions, they should just make sure they can pass the data they want to filter as an argument. Is this clear in how its written? Do I need to edit it to make it more clear?. Clarified with a note

@hfaerber hfaerber linked a pull request Mar 7, 2023 that will close this issue
@hfaerber
Copy link
Contributor

hfaerber commented Mar 23, 2023

PR for updated starter kit repo *Will merge to main when I get thumbs up from Nick

PR for updated project spec (already reviewed and approved though more reviewing eyes are always welcome!) *Merged into development

This PR also has some small edits to other projects/files:

  • linking correct spec on FE site
  • adding "you bail, you fail" note to other M1 collab projects
  • adding purity as a WOW to other M1 projects
  • revising M1 TICTACTOE final to only require 1 js file

@hfaerber
Copy link
Contributor

Both WC part 1 PRS have been merged.
Spec - merged to development
Starter Repo - merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M2 M2 task Project An issue affecting a project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants