Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paired project 2 #582

Closed
wvmitchell opened this issue Jan 12, 2023 · 4 comments · Fixed by #652
Closed

Update paired project 2 #582

wvmitchell opened this issue Jan 12, 2023 · 4 comments · Fixed by #652
Assignees
Labels
M1 M1 task Project An issue affecting a project

Comments

@wvmitchell
Copy link
Collaborator

Project to be updated: Rom Com

Summary of changes needed:

  • The project currently pushes students to make use of a Cover class, this should be replaced with some guidance on how to store the information about a cover in an object literal
  • Reference to using the Cover class should likewise be updated
  • The boilerplate Cover class should be removed from the starter repo
  • All group projects should make clear that a failure to participate can result in an individual failing the project, even if the project is otherwise passing
@wvmitchell wvmitchell added M1 M1 task Project An issue affecting a project labels Jan 12, 2023
@hfaerber hfaerber self-assigned this Mar 17, 2023
@hfaerber
Copy link
Contributor

hfaerber commented Mar 21, 2023

PR for starter-repo updates - here

PR for project spec - here

@hfaerber
Copy link
Contributor

hfaerber commented Mar 21, 2023

Updating this brought up questions about the updates to the other paired project Hang In There:

  1. That spec states * All of your JavaScript will be written in domUpdates.js - you will not need to change any other files.
    There is no domUpdates.js file in the starter kit. Students will need to update both files, not just the dom file. Maybe we can also update the readme in the starter kit to help students understand what is expected in each file.
    ^^I'm in the process of updating this in both the spec and the file structure of the boilerplate repo. Confirming with M1 team how we want this set up

  2. The spec states as a WOW for functional programming competencies - Creating effective, clean methods in the provided createPoster function to manipulate object properties. They won't be creating methods within that function.
    ^^I ended up deleting this line altogether and put the function purity note in under that section instead of having it in the JS section

@CassandraGoose
Copy link
Contributor

I'm looking at this PR now - as long as the boilerplate README and the spec aren't contradicting each other, then I vote for just having the information in one spot. That way, if it ever changes, it only has to be changed in one spot. I've noticed that in general, we don't update things when updates are required in multiple areas and then we end up in situations where there are two totally different sets of instructions, which is more confusing for students.

I'm only one vote, though! I trust you and if you want to update the boilerplate README - go for it! 💪

@hfaerber
Copy link
Contributor

Thanks so much Cass! I removed the file structure outline from the README since its already noted in the spec (and as comments in the files themselves). Good call out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M1 M1 task Project An issue affecting a project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants