Skip to content

Commit f53e7f9

Browse files
authored
Merge pull request #106 from tumblr/stories/scale-to-fill-rendering
Stories: Scale to fill rendering + post-export overlays bug fixes
2 parents 9c73232 + 488fe1f commit f53e7f9

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

Classes/Editor/EditorView.swift

+5-2
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,11 @@ private struct EditorViewConstants {
120120
final class EditorView: UIView, MovableViewCanvasDelegate, MediaPlayerViewDelegate {
121121

122122
func didRenderRectChange(rect: CGRect) {
123-
drawingCanvasConstraints.update(with: rect)
124-
movableViewCanvasConstraints.update(with: rect)
123+
if playerView?.contentMode != .scaleToFill {
124+
// When scaling to fill we don't need to update these views as they are already sized correctly.
125+
drawingCanvasConstraints.update(with: rect)
126+
movableViewCanvasConstraints.update(with: rect)
127+
}
125128
delegate?.didRenderRectChange(rect: rect)
126129
}
127130

Classes/Editor/MultiEditor/MultiEditorViewController.swift

+3
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,9 @@ extension MultiEditorViewController: EditorControllerDelegate {
374374
editor.export { [weak self, editor] result in
375375
let _ = editor // strong reference until the export completes
376376
self?.exportHandler.handleExport(result, for: idx)
377+
if let selected = self?.selected {
378+
self?.loadEditor(for: selected)
379+
}
377380
}
378381
}
379382
})

Kanvas.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |spec|
22
spec.name = "Kanvas"
3-
spec.version = "1.2.4"
3+
spec.version = "1.2.5"
44
spec.summary = "A custom camera built for iOS."
55
spec.homepage = "https://github.com/tumblr/kanvas-ios"
66
spec.license = "MPLv2"

0 commit comments

Comments
 (0)