-
Notifications
You must be signed in to change notification settings - Fork 1
Integration COCCON Spain #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dostuffthatmatters
wants to merge
10
commits into
main
Choose a base branch
from
dev-coccon-spain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pyra-4-documentation canceled.
|
6de9a1c to
6362d88
Compare
Add enclosure interface
Add enclosure types
Add enclosure logger
Add config and state to central schemas
Extend enclosure interface
Add enclosure thread
Add coccon spain thread to mainloop
Fix CI tests
Add UI code
e6f3243 to
4779797
Compare
✅ Deploy Preview for pyra-4-documentation canceled.
|
Update enclosure code after rebasing to 4.2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to do for Pyra Core:
Define the config variables you need in
packages/core/types/enclosures/coccon_spain_enclosure.pyEverything that should be configurable without a software update.
Define the state variables you need in
packages/core/types/enclosures/coccon_spain_enclosure.pyEverything you need in the operational logic inside Pyra (humidity, enclosure position, etc.) or that you want to display in the UI.
Define the functions how to read from/write to the datalogger in
packages/core/interfaces/enclosures/coccon_spain_enclosure_interface.pyprobably simply HTTP requests
Define the operational logic inside
packages/core/threads/enclosures/coccon_spain_enclosure_thread.pypowering up/down the spectrometer, opening/closing the cover, etc.
Define the datalogger variables you want to archive in CSV files in
packages/core/utils/coccon_spain_enclosure_logger.pyThings to do for the UI:
packages/ui/src/utils/zustand-utils/config-zustand.tsandpackages/ui/src/custom-types.tspackages/ui/src/utils/zustand-utils/core-state-zustand.tspackages/ui/src/components/overview/system-state.tsxYou can look at the TUM Enclosure equivalents of these files to get an inspiration of what could be done. Feel free to ping me here if you have any questions.