Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mod to follow best practices better #5

Open
tckarenchiang opened this issue May 28, 2021 · 2 comments
Open

Refactor mod to follow best practices better #5

tckarenchiang opened this issue May 28, 2021 · 2 comments
Labels
enhancement New feature or request lua Issues requiring changes/fixes to the Lua code

Comments

@tckarenchiang
Copy link
Contributor

tckarenchiang commented May 28, 2021

Since we have quite a number of additional lua files, sometimes it's hard to find the right file.

We should categorize them into different sub-directories of the lua folder.

E.g. all ros messages helper functions into a folder called ros_messages, etc.

@gavanderhoorn gavanderhoorn added enhancement New feature or request lua Issues requiring changes/fixes to the Lua code labels Jun 1, 2021
@gavanderhoorn gavanderhoorn changed the title Move lua helper files to subdir of the 'lua' folder Refactor mod to follow best practices better Jun 8, 2021
@gavanderhoorn
Copy link
Member

@tckarenchiang: I've updated the title of the issue to change the focus, as I believe it would be good to refactor the mod in its entirety to follow best-practices better instead of simply moving files around.

There are some good quality mods which we could use as inspiration/templates (Seasons, Courseplay, GuidanceSteering).

@gavanderhoorn
Copy link
Member

#41 also works towards this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lua Issues requiring changes/fixes to the Lua code
Development

No branches or pull requests

2 participants