Test case for AuthorizationError.

Author: jaredhanson

lib/errors/authorizationerror.js

@@ -1,6 +1,17 @@
 /**
  * `AuthorizationError` error.
  *
+ * AuthorizationError represents an error in response to an authorization
+ * request.  For details, refer to RFC 6749, section 4.1.2.1.
+ *
+ * References:
+ *   - [The OAuth 2.0 Authorization Framework](http://tools.ietf.org/html/rfc6749)
+ *
+ * @constructor
+ * @param {String} [message]
+ * @param {String} [code]
+ * @param {String} [uri]
+ * @param {Number} [status]
  * @api public
  */
 function AuthorizationError(message, code, uri, status) {
@@ -15,7 +26,7 @@ function AuthorizationError(message, code, uri, status) {
   Error.call(this);
   Error.captureStackTrace(this, arguments.callee);
   this.name = 'AuthorizationError';
-  this.message = message || 'OAuth 2.0 authorization request failed';
+  this.message = message;
   this.code = code || 'server_error';
   this.uri = uri;
   this.status = status || 500;

lib/errors/internaloautherror.js

@@ -27,7 +27,8 @@ InternalOAuthError.prototype.__proto__ = Error.prototype;
  * @api public
  */
 InternalOAuthError.prototype.toString = function() {
-  var m = this.name + ': ' + this.message;
+  var m = this.name;
+  if (this.message) { m += ': ' + this.message; }
   if (this.oauthError) {
     if (this.oauthError instanceof Error) {
       m = this.oauthError.toString();

test/errors/authorizationerror.test.js

@@ -0,0 +1,84 @@
+var AuthorizationError = require('../../lib/errors/authorizationerror');
+
+
+describe('AuthorizationError', function() {
+    
+  describe('constructed without a message', function() {
+    var err = new AuthorizationError();
+    
+    it('should have default properties', function() {
+      expect(err.message).to.be.undefined;
+      expect(err.code).to.equal('server_error');
+      expect(err.uri).to.be.undefined;
+      expect(err.status).to.equal(500);
+    });
+    
+    it('should format correctly', function() {
+      expect(err.toString()).to.equal('AuthorizationError');
+    });
+  });
+  
+  describe('constructed with a message', function() {
+    var err = new AuthorizationError('Invalid return URI');
+    
+    it('should have default properties', function() {
+      expect(err.message).to.equal('Invalid return URI');
+      expect(err.code).to.equal('server_error');
+      expect(err.uri).to.be.undefined;
+      expect(err.status).to.equal(500);
+    });
+    
+    it('should format correctly', function() {
+      expect(err.toString()).to.equal('AuthorizationError: Invalid return URI');
+    });
+  });
+  
+  describe('constructed with a message and access_denied code', function() {
+    var err = new AuthorizationError('Access denied', 'access_denied');
+    
+    it('should have default properties', function() {
+      expect(err.message).to.equal('Access denied');
+      expect(err.code).to.equal('access_denied');
+      expect(err.uri).to.be.undefined;
+      expect(err.status).to.equal(403);
+    });
+  });
+  
+  describe('constructed with a message and server_error code', function() {
+    var err = new AuthorizationError('Server error', 'server_error');
+    
+    it('should have default properties', function() {
+      expect(err.message).to.equal('Server error');
+      expect(err.code).to.equal('server_error');
+      expect(err.uri).to.be.undefined;
+      expect(err.status).to.equal(502);
+    });
+  });
+  
+  describe('constructed with a message and temporarily_unavailable code', function() {
+    var err = new AuthorizationError('Temporarily unavailable', 'temporarily_unavailable');
+    
+    it('should have default properties', function() {
+      expect(err.message).to.equal('Temporarily unavailable');
+      expect(err.code).to.equal('temporarily_unavailable');
+      expect(err.uri).to.be.undefined;
+      expect(err.status).to.equal(503);
+    });
+  });
+  
+  describe('constructed with a message, code, uri and status', function() {
+    var err = new AuthorizationError('Unsupported response type: foo', 'unsupported_response_type', 'http://www.example.com/oauth/help', 501);
+    
+    it('should have default properties', function() {
+      expect(err.message).to.equal('Unsupported response type: foo');
+      expect(err.code).to.equal('unsupported_response_type');
+      expect(err.uri).to.equal('http://www.example.com/oauth/help');
+      expect(err.status).to.equal(501);
+    });
+    
+    it('should format correctly', function() {
+      expect(err.toString()).to.equal('AuthorizationError: Unsupported response type: foo');
+    });
+  });
+  
+});

test/errors/internaloautherror.test.js

@@ -3,6 +3,14 @@ var InternalOAuthError = require('../../lib/errors/internaloautherror');
 
 describe('InternalOAuthError', function() {
 
+  describe('constructed without a message', function() {
+    var err = new InternalOAuthError();
+    
+    it('should format correctly', function() {
+      expect(err.toString()).to.equal('InternalOAuthError');
+    });
+  });
+    
   describe('constructed with a message', function() {
     var err = new InternalOAuthError('oops');
 

test/strategies/oauth2.normal.test.js

@@ -291,7 +291,7 @@ describe('OAuth2Strategy', function() {
 
     it('should error', function() {
       expect(err).to.be.an.instanceof(AuthorizationError)
-      expect(err.message).to.equal('OAuth 2.0 authorization request failed');
+      expect(err.message).to.be.undefined;
       expect(err.code).to.equal('invalid_scope');
       expect(err.uri).to.be.undefined;
       expect(err.status).to.equal(500);