Fix vortex street elixir (#2360)

* Fix vortex street elixir

* Use constant density

* Reset tspan

* Fix tests

---------

Co-authored-by: Hendrik Ranocha <[email protected]>

Author: efaulhaber

Diff for: examples/p4est_2d_dgsem/elixir_navierstokes_vortex_street.jl

@@ -5,24 +5,25 @@ using Trixi
 # Semidiscretization of the compressible Euler equations
 
 # Fluid parameters
-const gamma = 5 / 3
+const gamma = 1.4
 const prandtl_number = 0.72
 
 # Parameters for compressible von-Karman vortex street
-const Re = 500
+const Re = 200
 const Ma = 0.5f0
 const D = 1 # Diameter of the cylinder as in the mesh file
 
 # Parameters that can be freely chosen
 const v_in = 1
-const p_in = 1
+const rho_in = 1
 
 # Parameters that follow from Reynolds and Mach number + adiabatic index gamma
-const mu = v_in * D / Re
+const nu = v_in * D / Re
 
 const c = v_in / Ma
 const p_over_rho = c^2 / gamma
-const rho_in = p_in / p_over_rho
+const p_in = rho_in * p_over_rho
+const mu = rho_in * nu
 
 # Equations for this configuration
 equations = CompressibleEulerEquations2D(gamma)
@@ -101,7 +102,7 @@ analysis_callback = AnalysisCallback(semi, interval = analysis_interval)
 
 alive_callback = AliveCallback(analysis_interval = analysis_interval)
 
-save_solution = SaveSolutionCallback(interval = analysis_interval,
+save_solution = SaveSolutionCallback(dt = 1.0,
                                      save_initial_solution = true,
                                      save_final_solution = true,
                                      solution_variables = cons2prim)

Diff for: test/test_parabolic_2d.jl

@@ -50,7 +50,7 @@ isdir(outdir) && rm(outdir, recursive = true)
         fill!(gradients[dim], zero(eltype(gradients[dim])))
     end
 
-    # unpack VectorOfArray 
+    # unpack VectorOfArray
     u0 = Base.parent(ode.u0)
     t = 0.0
     # pass in `boundary_condition_periodic` to skip boundary flux/integral evaluation
@@ -898,16 +898,16 @@ end
     @test_trixi_include(joinpath(examples_dir(), "p4est_2d_dgsem",
                                  "elixir_navierstokes_vortex_street.jl"),
                         l2=[
-                            0.00525982921933851,
-                            0.012059890474305961,
-                            0.00958808867603675,
-                            0.027447629432184845
+                            0.012420217727434794,
+                            0.028935260981567217,
+                            0.023078384429351353,
+                            0.11317643179072025
                         ],
                         linf=[
-                            0.21303186936723756,
-                            0.5323378916431336,
-                            0.2929673561258163,
-                            0.9497315029535995
+                            0.4484833725983406,
+                            1.268913882714608,
+                            0.7071821629898418,
+                            3.643975012834931
                         ],
                         tspan=(0.0, 1.0))
     # Ensure that we do not have excessive memory allocations