Skip to content

Update to Chrome 74 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steebchen opened this issue May 3, 2019 · 4 comments
Closed

Update to Chrome 74 #10

steebchen opened this issue May 3, 2019 · 4 comments

Comments

@steebchen
Copy link

This version of ChromeDriver only supports Chrome version 74

current chrome installed in this docker image is v73.x

@everflux
Copy link
Contributor

everflux commented May 5, 2019

Should be fixed in the :latest tag.
Unfortunately protractor/chrome-webdriver is bumping the required minimum chrome version while beeing kept up-to date, so a build can start to fail without any changes. I don't see how a permanent fix could work due to the implementation of the chrome-webdriver update mechanism. Only option is to build a new image with the latest chrome/chromium version.

@everflux everflux closed this as completed May 5, 2019
@steebchen
Copy link
Author

steebchen commented May 5, 2019

Thanks! Maybe you could setup a build once per day somehow and push to latest? GH actions can schedule builds. If not I'll probably fork it and set it up myself in the long term.

@everflux
Copy link
Contributor

everflux commented May 5, 2019

Even once per day will not completely solve the problem, since the release of a newer webdriver/chromebrowser can happen at any time and will break your build in the angular context.
The underlying problem is the automatic behaviour of the webdriver-manager and they themself have this issue in their tracker at regular intervals:
angular/webdriver-manager#376
angular/webdriver-manager#373
angular/webdriver-manager#358
angular/webdriver-manager#353
angular/webdriver-manager#328

To me it looks deeply broken (by design) and there is not to do from the docker image point of view, but of course more regular builds might shadow the real problem. (Currently in the Angular 8 phase, there are not much angular-cli versions coming, which drove more regular builds in the past.)

@steebchen
Copy link
Author

Hm.. I agree. I think I'll just update chrome every time to fix the problem for now (e2es are slow anyway, the extra chrome update won't matter for me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants