Skip to content

Commit c823256

Browse files
wendigohashhar
authored andcommitted
Extract client capabilities values
1 parent a102ca3 commit c823256

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

tests/unit/test_client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def assert_headers(headers):
135135
assert headers[constants.HEADER_SESSION] == ""
136136
assert headers[constants.HEADER_TRANSACTION] is None
137137
assert headers[constants.HEADER_TIMEZONE] == timezone
138-
assert headers[constants.HEADER_CLIENT_CAPABILITIES] == "PARAMETRIC_DATETIME,SESSION_AUTHORIZATION"
138+
assert headers[constants.HEADER_CLIENT_CAPABILITIES] == constants.CLIENT_CAPABILITIES
139139
assert headers[accept_encoding_header] == accept_encoding_value
140140
assert headers[client_info_header] == client_info_value
141141
assert headers[constants.HEADER_ROLE] == (

trino/client.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,8 @@ def http_headers(self) -> CaseInsensitiveDict[str]:
522522
headers[constants.HEADER_ENCODING] = self._client_session.encoding
523523
else:
524524
raise ValueError("Invalid type for encoding: expected str or list")
525-
headers[constants.HEADER_CLIENT_CAPABILITIES] = 'PARAMETRIC_DATETIME,SESSION_AUTHORIZATION'
525+
headers[constants.HEADER_CLIENT_CAPABILITIES] = constants.CLIENT_CAPABILITIES
526+
526527
headers["user-agent"] = f"{constants.CLIENT_NAME}/{__version__}"
527528
if len(self._client_session.roles.values()):
528529
headers[constants.HEADER_ROLE] = ",".join(

trino/constants.py

+3
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@
5757
HEADER_SET_CATALOG = "X-Trino-Set-Catalog"
5858

5959
HEADER_CLIENT_CAPABILITIES = "X-Trino-Client-Capabilities"
60+
CLIENT_CAPABILITY_PARAMETRIC_DATETIME = "PARAMETRIC_DATETIME"
61+
CLIENT_CAPABILITY_SESSION_AUTHORIZATION = "SESSION_AUTHORIZATION"
62+
CLIENT_CAPABILITIES = ','.join([CLIENT_CAPABILITY_PARAMETRIC_DATETIME, CLIENT_CAPABILITY_SESSION_AUTHORIZATION])
6063

6164
HEADER_AUTHORIZATION_USER = "X-Trino-Authorization-User"
6265
HEADER_SET_AUTHORIZATION_USER = "X-Trino-Set-Authorization-User"

0 commit comments

Comments
 (0)