Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRI-4324] Allow ignoring some glob patterns in trigger.config (e.g. **/*.test.*) #1593

Closed
matt-aitken opened this issue Jan 9, 2025 · 0 comments · Fixed by #1600
Closed

[TRI-4324] Allow ignoring some glob patterns in trigger.config (e.g. **/*.test.*) #1593

matt-aitken opened this issue Jan 9, 2025 · 0 comments · Fixed by #1600

Comments

@matt-aitken
Copy link
Member

matt-aitken commented Jan 9, 2025 •
edited
Loading

At the moment having .test or .spec files in your trigger directories can cause issues with compilation.

We should support an ignore array of globs. Files matching the patterns wouldn't be included in the build.

ignore: ["**/*.test.*", "**/*.spec.*"]

TRI-4324
@matt-aitken matt-aitken changed the title Allow ignoring some glob patterns in trigger.config (e.g. **/*.test.*) [TRI-4324] Allow ignoring some glob patterns in trigger.config (e.g. **/*.test.*) Jan 9, 2025
ericallam added a commit that referenced this issue Jan 10, 2025
@ericallam
Support ignoring test/spec files inside trigger dirs (fixes #1593)
ad8b245
ericallam added a commit that referenced this issue Jan 10, 2025
@ericallam
Support ignoring test/spec files inside trigger dirs (fixes #1593)
c1d92fb
@github-actions github-actions bot mentioned this issue Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update version for release triggerdotdev/trigger.dev
1 participant
@matt-aitken