Skip to content

Commit e6b6b52

Browse files
MariefayTrigger.dev RepoOps
authored andcommitted
perf(webapp): lower the default progressive trace view cap to 150k spans
Progressive trace loading now shows up to 150k spans by default (configurable with EVENTS_CLICKHOUSE_MAX_TRACE_VIEW_COUNT). Mono-RevId: a3b877a9ea47243ca687e8be8056f448eb9d0b10
1 parent 79c5c39 commit e6b6b52

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎apps/webapp/app/env.server.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2442,7 +2442,7 @@ const EnvironmentSchema = z
24422442
EVENTS_CLICKHOUSE_MAX_TRACE_DETAILED_SUMMARY_VIEW_COUNT: z.coerce.number().int().default(5_000),
24432443
EVENTS_CLICKHOUSE_MAX_LIVE_RELOADING_SETTING: z.coerce.number().int().default(2000),
24442444
EVENTS_CLICKHOUSE_TRACE_CHUNK_SIZE: z.coerce.number().int().positive().default(1_000),
2445-
EVENTS_CLICKHOUSE_MAX_TRACE_VIEW_COUNT: z.coerce.number().int().positive().default(250_000),
2445+
EVENTS_CLICKHOUSE_MAX_TRACE_VIEW_COUNT: z.coerce.number().int().positive().default(150_000),
24462446

24472447
// OTLP ingest transform worker pool (opt-in). When enabled, decode/convert/enrich run in a
24482448
// worker_threads pool instead of the request event loop; the single consolidated insert path

‎apps/webapp/app/hooks/useProgressiveTrace.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616

1717
const MAX_CHUNK_ATTEMPTS = 3;
1818
const RETRY_BACKOFF_MS = 400;
19-
const MAX_PROGRESSIVE_SPANS = 250_000;
19+
const MAX_PROGRESSIVE_SPANS = 150_000;
2020
const BACKGROUND_CHUNK_SIZE = 10_000;
2121
const REBUILD_COALESCE_MS = 100;
2222
const TAIL_FETCH_TIMEOUT_MS = 15_000;

‎apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ export class ClickhouseEventRepository implements IEventRepository {
358358
}
359359

360360
get maximumTraceViewCount() {
361-
return this._config.maximumTraceViewCount ?? 250_000;
361+
return this._config.maximumTraceViewCount ?? 150_000;
362362
}
363363

364364
get maximumErrorMatches() {

0 commit comments

Comments
 (0)