fix: respect max elapsed in backoff execute

Author: nikhil-shukl

.changeset/respect-backoff-max-elapsed.md

@@ -0,0 +1,5 @@
+---
+"@trigger.dev/core": patch
+---
+
+Stop `ExponentialBackoff.execute()` retries when callback execution time pushes the run past `maxElapsed`.

packages/core/src/v3/apps/backoff.ts

@@ -98,7 +98,6 @@ export class ExponentialBackoff {
     return this.#clone(undefined, { maxRetries });
   }
 
-  // TODO: With .execute(), should this also include the time it takes to execute the callback?
   maxElapsed(maxElapsed?: number) {
     return this.#clone(undefined, { maxElapsed });
   }
@@ -340,6 +339,14 @@ export class ExponentialBackoff {
         elapsedMs += Date.now() - start;
         clearTimeout(attemptTimeout);
       }
+
+      if (elapsedMs / 1000 > this.#maxElapsed) {
+        return {
+          success: false,
+          cause: "Timeout",
+          error: finalError,
+        };
+      }
     }
 
     if (finalError instanceof AttemptTimeout) {

packages/core/test/backoff.test.ts

@@ -0,0 +1,27 @@
+import { describe, expect, it } from "vitest";
+import { ExponentialBackoff } from "../src/v3/apps/backoff.js";
+
+describe("ExponentialBackoff", () => {
+  it("stops execute retries when callback time exceeds maxElapsed", async () => {
+    const backoff = new ExponentialBackoff("NoJitter", {
+      factor: 0,
+      maxElapsed: 0.01,
+      maxRetries: 5,
+    });
+    const error = new Error("retryable");
+    let attempts = 0;
+
+    const result = await backoff.execute(async () => {
+      attempts++;
+      await new Promise((resolve) => setTimeout(resolve, 25));
+      throw error;
+    });
+
+    expect(result).toEqual({
+      success: false,
+      cause: "Timeout",
+      error,
+    });
+    expect(attempts).toBe(1);
+  });
+});