Commit ce51b31
committed
docs(run-engine): correct the reasoning on the acknowledged-run guard
The guard that stops a returned message being written back when its payload is
gone was described as cleaning up an orphaned list entry. It is load-bearing:
an acknowledgement landing between the candidate read and the script leaves a
claimable worker queue entry whose run has already completed, and without the
guard the sweep would put that completed run back on the pending queue.
Also aligns two test doubles with the renamed result field.1 parent 08a50d7 commit ce51b31
3 files changed
Lines changed: 6 additions & 4 deletions
File tree
- apps/webapp/test
- internal-packages/run-engine/src/run-queue
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4846 | 4846 | | |
4847 | 4847 | | |
4848 | 4848 | | |
4849 | | - | |
| 4849 | + | |
| 4850 | + | |
4850 | 4851 | | |
4851 | 4852 | | |
4852 | 4853 | | |
| |||
4927 | 4928 | | |
4928 | 4929 | | |
4929 | 4930 | | |
4930 | | - | |
| 4931 | + | |
| 4932 | + | |
4931 | 4933 | | |
4932 | 4934 | | |
4933 | 4935 | | |
| |||
0 commit comments